import types #2192
import types #2192
Conversation
There was a problem hiding this comment.
Ecstatic. I think I found the CI failure. Your changes were mechanical, but there was an existing type reference error that had gone unnoticed somehow. I changed one imported type from Remotable to RemotableObject and appended that commit to your branch (1faea7a). Paging @erights if that’s consistent with the design.
Yes. Glad to see this happening! |
|
windows-latest failed. But it is known to be flaky so I restarted it. |
Thanks. I squashed that into the commit that has the others. I also added the patch that agoric-sdk needed. Since you reviewed that in Agoric/agoric-sdk#9185 @kriskowal I'm not requesting re-review before merging. |
|
Just reran the flaky windows-latest again |
## Description Follow up #2192 I think this wraps up the transition, save for the TODO. ### Security Considerations n/a, typedefs ### Scaling Considerations n/a, typedefs ### Documentation Considerations not necessary ### Testing Considerations CI ### Compatibility Considerations Some reduction in exports, but those were deep imports so ok to break ### Upgrade Considerations none
Description
Uses
@importfrom upcoming TS 5.5, like Agoric/agoric-sdk#9149Also includes the changes needed in Agoric/agoric-sdk@83db366
Security Considerations
Nightly build of TypeScript
Scaling Considerations
no runtime changes
Documentation Considerations
nothing to change
Testing Considerations
CI
Compatibility Considerations
Increases compatibility with agoric-sdk
Upgrade Considerations
no runtime changes
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.