Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

$ sign should be encoded for media endpoint #564

Closed
wants to merge 1 commit into from

Conversation

sadiqkhoja
Copy link

Closes getodk/central#433

What's happing:

Request from browser:            `http://localhost/-/media/get/1/uuid:one/%24dollar-10_36_6.jpg`
request.url in getHostURLOption:                         `/get/1/uuid:one/$dollar-10_36_6.jpg`

%24 is decoded to $, but if the request has %2524 then it is not decoded to %24 which is quite strange. To me it looks like it has something to do with this expressjs/express#2987 - but I am not fully certain.

@alxndrsn
Copy link
Contributor

alxndrsn commented Jun 2, 2023

Is it possible that the $ should never have been percent-encoded in the first place?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submissions with attachments with unicode filenames are not saved
2 participants