Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unresolvable selected items in Content Selector #6026

Closed
alansemenov opened this issue Mar 8, 2023 · 1 comment · Fixed by #7561
Closed

Handle unresolvable selected items in Content Selector #6026

alansemenov opened this issue Mar 8, 2023 · 1 comment · Fixed by #7561
Assignees
Labels
Improvement Suggestion for improvement

Comments

@alansemenov
Copy link
Member

We handle selected images that cannot be resolved in Image Selector:
image

But we don't handle selected content items that cannot be resolved in Content & Media Selectors - missing items simply won't be shown as if nothing was selected. We should display placeholders for content items that cannot be resolved (note that this may also happen because of the lack of permissions).

Verify that the fix also works for content selector inside "Insert Link" dialog in HtmlArea.

image

@alansemenov alansemenov added the Improvement Suggestion for improvement label Mar 8, 2023
@alansemenov alansemenov changed the title Handle unresolvable items selected in Content Selector Handle unresolvable selected items in Content Selector Mar 8, 2023
@sigdestad
Copy link
Member

It would be really great if we can show some more details than "not found" i.e. there are multiplereasons why this may happen:

  1. Content has been deleted/missing (404 style)
  2. User cannot read content (401)

AFAIK Today, we also show a "yellow warning" when editing a page/item with broken links and we automatically break missing references. I think this new approach is a much better solution - where user must decided to remove the refs, but then user needs to know if link is broken - or he/she does not have access.

Error message could be

  1. Not found
  2. Access denied

alansemenov pushed a commit that referenced this issue May 3, 2024
Handle unresolvable selected items in Content Selector #6026
alansemenov pushed a commit that referenced this issue May 4, 2024
Handle unresolvable selected items in Content Selector #6026
ashklianko added a commit that referenced this issue May 6, 2024
- setting selected options correctly without triggering unnecessary updates
- Using same selected option value object class so that selected item could be easily updated to missing one and vice versa
ashklianko added a commit that referenced this issue May 6, 2024
- setting selected options correctly without triggering unnecessary updates
- Using same selected option value object class so that selected item could be easily updated to missing one and vice versa
ashklianko added a commit that referenced this issue May 7, 2024
- setting selected options correctly without triggering unnecessary updates
- Using same selected option value object class so that selected item could be easily updated to missing one and vice versa
alansemenov pushed a commit that referenced this issue May 13, 2024
ContentSelector: selected items statuses disappear after content update #7562
ImageSelector: handle archive/delete/restore of selected items #7563
Handle unresolvable selected items in Content Selector #6026
alansemenov pushed a commit that referenced this issue May 13, 2024
ContentSelector: selected items statuses disappear after content update #7562
ImageSelector: handle archive/delete/restore of selected items #7563
Handle unresolvable selected items in Content Selector #6026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Suggestion for improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants