Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing Wizard allows publishing before dependencies are loaded #7051

Closed
edloidas opened this issue Nov 10, 2023 · 0 comments · Fixed by #7054
Closed

Publishing Wizard allows publishing before dependencies are loaded #7051

edloidas opened this issue Nov 10, 2023 · 0 comments · Fixed by #7054
Assignees
@edloidas
Labels
Bug Something isn't working

Comments

@edloidas
Copy link
Member

If the network connection is slow enough, there is might be a delay between two requests, when we fetch all the data and then exclude all dependencies. If it takes long enough, the UI redrawn with the first data and some of the messages in notifications area may appear, when they should not.
The solution is to wait until all the requests have finished and only then update the UI.
@edloidas edloidas added the Bug Something isn't working label Nov 10, 2023
@edloidas edloidas self-assigned this Nov 10, 2023
@alansemenov alansemenov changed the title Content Publish Dialog redners wrong data during loading Content Publish Dialog renders wrong data during loading Nov 13, 2023
@alansemenov alansemenov changed the title Content Publish Dialog renders wrong data during loading Publishing Wizard allows publishing before dependencies are loaded Nov 13, 2023
edloidas added a commit that referenced this issue Nov 13, 2023
@edloidas
Publishing Wizard allows publishing before dependencies are loaded #7051
d968185 


Prevented the dialog to be unlocked by the "update" event (usually comes from the "mark as ready" in wizard, while still fetching data.
Fixed the "show/hide excluded" text on first load, that may be visible on slow networks.
Disabled "show/hide excluded" while controls are locked.
@edloidas edloidas linked a pull request Nov 13, 2023 that will close this issue
Publishing Wizard allows publishing before dependencies are loaded #7051 #7054
Merged
edloidas added a commit that referenced this issue Nov 14, 2023
@edloidas
Publishing Wizard allows publishing before dependencies are loaded #7051
550b7ae 


Prevented the dialog from being unlocked by the "update" event (usually comes from the "mark as ready" in the wizard, while still fetching data.
Disabled "show/hide excluded" while controls are locked.
alansemenov pushed a commit that referenced this issue Nov 14, 2023
@edloidas @alansemenov
Publishing Wizard allows publishing before dependencies are loaded #7051
a1f2e6b 


Prevented the dialog from being unlocked by the "update" event (usually comes from the "mark as ready" in the wizard, while still fetching data.
Disabled "show/hide excluded" while controls are locked.
alansemenov pushed a commit that referenced this issue Nov 14, 2023
@edloidas @alansemenov
Publishing Wizard allows publishing before dependencies are loaded #7051
c2dbf4c 


Prevented the dialog from being unlocked by the "update" event (usually comes from the "mark as ready" in the wizard, while still fetching data.
Disabled "show/hide excluded" while controls are locked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edloidas edloidas

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publishing Wizard allows publishing before dependencies are loaded #7051 enonic/app-contentstudio
1 participant
@edloidas