Remove redundant elements from TextComponentView #4985 #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are ok, also @sgauruseu confirms that after manual check everything seems fine, however there are some errors in console that do no affect behavior, will check them first |
+tests from @sgaurseu
ashklianko
force-pushed
the
issue-4985
branch
from
4f1fcc3
to
39bf34e
Compare
|
Can be merged now |
alansemenov
approved these changes
Jan 11, 2023
alansemenov
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-removed redundant element that used to store and show editor's content when not in edit mode