Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a component path to every component data #325

Closed
pmi opened this issue Jul 8, 2022 · 6 comments · Fixed by #341
Closed

Add a component path to every component data #325

pmi opened this issue Jul 8, 2022 · 6 comments · Fixed by #341
Assignees
Labels
improvement Existing functionality was enhanced

Comments

@pmi
Copy link
Member

pmi commented Jul 8, 2022

No description provided.

@pmi pmi self-assigned this Jul 8, 2022
@alansemenov alansemenov linked a pull request Jul 26, 2022 that will close this issue
@poi33
Copy link
Contributor

poi33 commented Aug 16, 2022

@pmi done, close?

@pmi
Copy link
Member Author

pmi commented Aug 16, 2022

Hm, it says that it's archived in NextJS project, and should've been closed by merge of the PR

@pmi
Copy link
Member Author

pmi commented Aug 16, 2022

@alansemenov Is that correct that it is not closed after PR is merged ?

@poi33
Copy link
Contributor

poi33 commented Aug 16, 2022

I was wondering about this too. We probably don't want auto close as this is done after every sprint

@alansemenov
Copy link
Member

@alansemenov Is that correct that it is not closed after PR is merged ?

Unfortunately, it's not (yet) automatic in Github projects :(. The one who merges a PR, should change status (or drag the issue) to "Done". You can close the issue as well, it will still remain in "Done". After sprint review we'll archive everything in "Done", so that these issues disappear from the dashboard.

@alansemenov
Copy link
Member

Correction: the workflow was not entirely correct in the project. I've now changed it so that whenever an issue is closed (with the "Close" button), it will be automatically moved to "Done". So, whoever merges a PR, should close the issue. It will be moved to "Done", then manually archived after sprint review.

@pmi pmi added the improvement Existing functionality was enhanced label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Existing functionality was enhanced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants