Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macroes inside parts don't render #354

Closed
poi33 opened this issue Aug 4, 2022 · 2 comments · Fixed by #408
Closed

Macroes inside parts don't render #354

poi33 opened this issue Aug 4, 2022 · 2 comments · Fixed by #408
Assignees
Labels
bug Something isn't working

Comments

@poi33
Copy link
Contributor

poi33 commented Aug 4, 2022

When using the macro the output is not shown and looks like:

<editor-macro data-macro-name="button" data-macro-ref="{_id}"></editor-macro>

Image

<p>
    <br>
    <editor-macro data-macro-name="button" data-macro-ref="6aa74b07-b7da-49cf-9681-dabc05761251"></editor-macro> 
    test
</p>

While a straight text component with a macro on the main page renders correctly:

Image

@poi33 poi33 assigned pmi Aug 4, 2022
@poi33 poi33 added the bug Something isn't working label Aug 4, 2022
@poi33
Copy link
Contributor Author

poi33 commented Aug 4, 2022

I tried to print out the processed macro. And it has the same tag.
Could this be a bug in guillotine?

pmi added a commit that referenced this issue Sep 16, 2022
@pmi pmi linked a pull request Sep 16, 2022 that will close this issue
@pmi
Copy link
Member

pmi commented Sep 16, 2022

I tried to print out the processed macro. And it has the same tag. Could this be a bug in guillotine?

No, this simply has not been implemented for parts

pmi added a commit that referenced this issue Sep 16, 2022
@pmi pmi closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants