Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix always on display #186

Merged
merged 4 commits into from Apr 16, 2020
Merged

fix always on display #186

merged 4 commits into from Apr 16, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2020

Seems to work on android Q with lineage os 17.1 .
Not tested on other devices.

@enricocid
Copy link
Owner

enricocid commented Apr 15, 2020

Thanks! Could You please modify the commit to add (and test) this?

if (VersioningHelper.isQ()) putLong(MediaMetadataCompat.METADATA_KEY_DURATION, currentSong.first?.duration!!)
putString(MediaMetadataCompat.METADATA_KEY_ARTIST, currentSong.first?.artist)
putString(MediaMetadataCompat.METADATA_KEY_AUTHOR, currentSong.first?.artist)
putString(MediaMetadataCompat.METADATA_KEY_COMPOSER, currentSong.first?.artist)
putString(MediaMetadataCompat.METADATA_KEY_TITLE, currentSong.first?.title)
putString(MediaMetadataCompat.METADATA_KEY_DISPLAY_TITLE, currentSong.first?.title)
putString(MediaMetadataCompat.METADATA_KEY_ALBUM_ARTIST, currentSong.first?.album)
putString(MediaMetadataCompat.METADATA_KEY_DISPLAY_SUBTITLE, currentSong.first?.album)
putString(MediaMetadataCompat.METADATA_KEY_ALBUM, currentSong.first?.album)
BitmapFactory.decodeResource(playerService.resources, R.drawable.ic_music_note)?.let { bmp ->
       putBitmap(MediaMetadataCompat.METADATA_KEY_DISPLAY_ICON, bmp)
}

Just to be sure to support different implementations. Also, could You please post a debug apk here so I can try it on 3rd party AOD/some ROM?
Thanks.

@ghost
Copy link
Author

ghost commented Apr 15, 2020

Done,
Everything seems to work as before on my device.
I added the APK at the root of the project (I dont know if there is other ways to send it).

@enricocid
Copy link
Owner

No no, don't add APK to the root of the project, just share it with gdrive or similar in the comments 😉

@ghost
Copy link
Author

ghost commented Apr 15, 2020

Ok here's the link to dowload the APK
https://send.firefox.com/download/2529cd5b94ac88ae/#j5jDY-2_GxqUgQEV7xtWxQ

@enricocid enricocid merged commit cb2241a into enricocid:master Apr 16, 2020
@enricocid
Copy link
Owner

Thanks, gonna release a new version this weekend 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant