Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/Optimize Coil Usage #287

Merged
merged 4 commits into from
Apr 25, 2021
Merged

Improve/Optimize Coil Usage #287

merged 4 commits into from
Apr 25, 2021

Commits on Mar 25, 2021

  1. Optimize now-playing cover loading 

    Do multiple things to make the cover loading on the now-playing screen more elegant
- Use a dedicated image loader bound to the application
- Get rid of the coroutines, coil already does it
- Completely use the Built-In "Load" method
- Move image builder init to GoApp
    @OxygenCobalt
    OxygenCobalt committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    220c703 View commit details
    Browse the repository at this point in the history

  2. Optimize coil usage on detail fragments 

    Do multiple things to streamline coil usage on DetailsFragment/MusicContainersListFragment
- Don't use custom ImageLoader
- Use the load extension method with the app-wide imageloader, removing the need for error drawables
- Removed the unneccisary coroutines
    @OxygenCobalt
    OxygenCobalt committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    6e08f84 View commit details
    Browse the repository at this point in the history

  3. Use coil on notification/mediasession 

    Use coil on the notification and the mediasession, instead of the old method that would halt execution.
    @OxygenCobalt
    OxygenCobalt committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    4e04551 View commit details
    Browse the repository at this point in the history

  4. Fix coil bugs 

    Fix some problems with the new coil usage:
- Enable bitmap pooling for efficency, but disable disk caching since it isnt needed
- Fix a problem where the metadata wouldnt properly update
- Fix a problem where the album detail view would respect the cover settings
    @OxygenCobalt
    OxygenCobalt committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    8e528db View commit details
    Browse the repository at this point in the history