Reduce ViewPager2 sensitivity #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, ViewPager2's sensitivity is high enough to result in vertical scroll events being registered as horizontal scroll events. Reflect into the internal recyclerview and change the touch slope so that touch actions will act more as a scroll than as a swipe.
|
Works great. Thank You :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that by default,
ViewPager2is far too sensitive for MPGO's scrolling views and fast scrollers, causing many non-swipe touch events to result in a swipe.This PR fixes that by doing some reflection magic and changing the internal
mTouchSlopvalue to favor scrolling during touch events instead of swiping. This should help improve UX somewhat.Feel free to raise any concerns with my change.