Set LC_ALL env var to prevent sbt/sbt-assembly#496

enso-org · Nov 13, 2023 · fe74103 · fe74103
1 parent c1115ba
commit fe74103
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/scala-new.yml b/.github/workflows/scala-new.yml
@@ -70,6 +70,7 @@ jobs:
  AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
  AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ LC_ALL: C.UTF-8
  - if: success() || failure()
  name: Engine Test Reporter
  uses: dorny/test-reporter@v1
@@ -149,6 +150,7 @@ jobs:
  AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
  AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ LC_ALL: C.UTF-8
  - if: success() || failure()
  name: Engine Test Reporter
  uses: dorny/test-reporter@v1
@@ -230,6 +232,7 @@ jobs:
  AWS_REGION: ${{ secrets.ENSO_LIB_S3_AWS_REGION }}
  AWS_SECRET_ACCESS_KEY: ${{ secrets.ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY }}
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ LC_ALL: C.UTF-8
  - if: success() || failure()
  name: Engine Test Reporter
  uses: dorny/test-reporter@v1

diff --git a/build/build/src/ci_gen/job.rs b/build/build/src/ci_gen/job.rs
@@ -281,7 +281,9 @@ impl JobArchetype for CiCheckBackend {
  .with_secret_exposed_as(
  secret::ENSO_LIB_S3_AWS_SECRET_ACCESS_KEY,
  crate::aws::env::AWS_SECRET_ACCESS_KEY,
- );
+ )
+ // This prevents https:/sbt/sbt-assembly/issues/496
+ .with_env("LC_ALL", "C.UTF-8");
  vec![main_step, step::engine_test_reporter(os), step::stdlib_test_reporter(os)]
  })
  .with_permission(Permission::Checks, Access::Write)

diff --git a/project/plugins.sbt b/project/plugins.sbt
@@ -1,4 +1,3 @@
-// sbt/sbt-assembly#496
 addSbtPlugin("com.sandinh" % "sbt-java-module-info" % "0.4.0")
 addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.1.3")
 addSbtPlugin("ch.epfl.scala" % "sbt-bloop" % "1.5.6")