Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dumb terminal - implement jline #8313

Closed
Akirathan opened this issue Nov 16, 2023 · 0 comments · Fixed by #8496
Closed

Remove dumb terminal - implement jline #8313

Akirathan opened this issue Nov 16, 2023 · 0 comments · Fixed by #8496
Assignees
Labels
--bug Type: bug -compiler d-easy Difficulty: little prior knowledge required x-chore Type: chore

Comments

@Akirathan
Copy link
Member

This is a follow-up task of #7991.

The following warning about inability to create a system terminal:

> /home/pavel/dev/enso/built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/bin/enso --repl
Nov 16, 2023 11:34:46 AM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)

Means that in the REPL, we will not have features like arrow-up, that normally searches for the last command. This makes REPL unusable because we cannot even use keyboard arrows, back search with CTRL + R, etc.

This can probably be easily fixed by including jline.jar in the component directory.

@Akirathan Akirathan added x-chore Type: chore --bug Type: bug -compiler labels Nov 16, 2023
@Akirathan Akirathan self-assigned this Nov 16, 2023
@Akirathan Akirathan added the d-easy Difficulty: little prior knowledge required label Nov 16, 2023
@mergify mergify bot closed this as completed in #8496 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -compiler d-easy Difficulty: little prior knowledge required x-chore Type: chore
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant