More detailed No_Such_Method error message for function like objects #10328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
JaroslavTulach
force-pushed
the
wip/jtulach/NoSuchMethodMessage10147
branch
from
873cc69
to
3eccee9
Compare
GregoryTravis
approved these changes
Jun 21, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Common.enso
Outdated
Show resolved
Hide resolved
Co-authored-by: GregoryTravis <[email protected]>
hubertp
approved these changes
Jun 25, 2024
radeusgd
reviewed
Jun 27, 2024
Comment on lines
+63
to
+66
| p . should_fail_with No_Such_Method | ||
| p.to_display_text . should_contain "Method `sample`" | ||
| p.to_display_text . should_contain "of ..B" | ||
| p.to_display_text . should_contain "not be found" |
There was a problem hiding this comment.
Thanks for addressing this! The new error message looks much more helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10147 by improving the error message for anything that looks like Enso
Function.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: