Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getDocuments on Windows #10350

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Fix getDocuments on Windows #10350

merged 5 commits into from
Jun 25, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jun 24, 2024

Pull Request Description

followup #10240

Changelog:

  • fix: enable desktop-environment SBT tests
  • fix: typo in Windows reg query

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 24, 2024
@4e6 4e6 self-assigned this Jun 24, 2024
@somebody1234
Copy link
Contributor

what does this do btw?

return stdoutString.split('\\s\\s+')[4]

@somebody1234
Copy link
Contributor

it looks kinda like a regex, but note that string literals are not regex literals (the docs for String.split may or may not be relevant?)

@4e6
Copy link
Contributor Author

4e6 commented Jun 24, 2024

it looks kinda like a regex

you are right. Thanks for pointing, I updated the logic

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Jun 24, 2024
@mergify mergify bot merged commit 8fba4b7 into develop Jun 25, 2024
41 of 42 checks passed
@mergify mergify bot deleted the wip/db/user-directory branch June 25, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants