Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signatures for distinct and duplicates #10365

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix signatures for distinct and duplicates #10365

merged 1 commit into from
Jun 25, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jun 25, 2024

Pull Request Description

Fixes #10364

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 25, 2024
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Jun 25, 2024
@mergify mergify bot merged commit 6bc7d4f into develop Jun 25, 2024
35 of 36 checks passed
@mergify mergify bot deleted the wip/adr/fix-distinct-duplicates branch June 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@marthasharkey marthasharkey marthasharkey approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinct nide throwing panic due to on_problems type
3 participants
@AdRiley @jdunkerley @marthasharkey