Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure identical Strings are shared #10409

Closed
wants to merge 1 commit into from
Closed

Make sure identical Strings are shared #10409

wants to merge 1 commit into from

Conversation

JaroslavTulach
Copy link
Member

Pull Request Description

Closes #10330 by making sure all Name.Literal instances share the same reference to Standard other strings.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    style guides.
  • Unit tests continue to pass
  • Manual measurement shows good results

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 1, 2024
@JaroslavTulach JaroslavTulach self-assigned this Jul 1, 2024
@JaroslavTulach
Copy link
Member Author

Module Original Size New Size
Standard.Base similar 31MB
Standard.Table similar 19MB
Standard.Database similar 17MB
Standard.Test similar 3,3MB
Standard.AWS similar 2,5MB
Standard.Snowflake similar 2,1MB
Standard.Visualization similar 1,9MB

I was seeing some improvements before creating the PR, but now I cannot find them! Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many duplicated Name.Literal instances
1 participant
@JaroslavTulach