Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Map to Dictionary and Set to Hashset. #10474

Merged
merged 22 commits into from
Jul 9, 2024
Merged

Rename Map to Dictionary and Set to Hashset. #10474

merged 22 commits into from
Jul 9, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 8, 2024 •
edited
Loading

Pull Request Description

  • Rename Map to Dictionary.
  • Rename Set to Hashset.
  • Add a deprecated place holder for the static method of Map.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley
Update Standard.Base.
aedbd29 
Update Standard.Examples.
@jdunkerley
Update Standard.AWS.
3138c70 
Update Standard.Snowflake.
Update Standard.Test.
Update Standard.Visualization.
First bit of test fixes.
@jdunkerley
Update Standard.Table.
4da4685 
Second bit of test fixes.
@jdunkerley
Update Standard.Table.
6452293 
Second bit of test fixes.
@jdunkerley
Update Standard.Database.
8aaebcc
@jdunkerley
More tests.
5c7246a
@jdunkerley jdunkerley added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jul 8, 2024
@jdunkerley
Typo.
2b6de6f 
Missing test.
@jdunkerley
CHANGELOG.
1c9dd54 
Deprecated copy of Map static methods.
@jdunkerley
Sort types.
5a916a9
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 9, 2024
@mergify mergify bot merged commit 4b3e4ae into develop Jul 9, 2024
41 checks passed
@mergify mergify bot deleted the wip/jd/Map-Dictionary branch July 9, 2024 09:12
radeusgd added a commit that referenced this pull request Jul 10, 2024
@radeusgd
adapt after #10474
dd682e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdRiley AdRiley AdRiley approved these changes

@Akirathan Akirathan Akirathan approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@marthasharkey marthasharkey marthasharkey approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jdunkerley @AdRiley @Akirathan @GregoryTravis @marthasharkey @JaroslavTulach