Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithWarnings uses EnsoHashMap to speed things up #10555

Merged
merged 80 commits into from
Aug 7, 2024
Merged

WithWarnings uses EnsoHashMap to speed things up #10555

merged 80 commits into from
Aug 7, 2024

Commits on Jul 15, 2024

  1. Refactor if instanceof to pattern-match variant

    @Akirathan
    Akirathan committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    77efb09 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. WithWarnings uses EnsoHashMap to store warnings

    @Akirathan
    Akirathan committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    061e9e4 View commit details
    Browse the repository at this point in the history

  2. MethodProcessor creates HashMapInsertNode in every builtin method

    @Akirathan
    Akirathan committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3a4d36c View commit details
    Browse the repository at this point in the history

  3. Annotations processor does not throw error, but uses processing env m… 

    …essenger instead
    @Akirathan
    Akirathan committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8f02245 View commit details
    Browse the repository at this point in the history

  4. Make some cached nodes in Warning Shared

    @Akirathan
    Akirathan committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d24bfeb View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Refactor WarningsTest to use ContextUtils

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6ff3915 View commit details
    Browse the repository at this point in the history

  2. Move all warning-related classes to new package

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    68bcbd6 View commit details
    Browse the repository at this point in the history

  3. WarningsLibrary is part of the type system

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    1c74dfe View commit details
    Browse the repository at this point in the history

  4. Use new HasWarningsNode instead of WarningsLibrary.hasWarnings

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a5dba6f View commit details
    Browse the repository at this point in the history

  5. Remove WarningsLibrary.hasWarnings message

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c4ab6b3 View commit details
    Browse the repository at this point in the history

  6. Fix infinite recursion in ArraySlice.readArrayElement

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a0dc44e View commit details
    Browse the repository at this point in the history

  7. GenerateUncached variants for ArrayLike nodes

    @Akirathan
    Akirathan committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b4d6c3f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Revert "Fix infinite recursion in ArraySlice.readArrayElement" 

    This reverts commit a0dc44e.
    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    120fdd4 View commit details
    Browse the repository at this point in the history

  2. Revert "Remove WarningsLibrary.hasWarnings message" 

    This reverts commit c4ab6b3.
    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3645231 View commit details
    Browse the repository at this point in the history

  3. Revert "Use new HasWarningsNode instead of WarningsLibrary.hasWarnings" 

    This reverts commit a5dba6f.
    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9e5edc5 View commit details
    Browse the repository at this point in the history

  4. Replace warning.attach by dedicated AppendWarningNode 

    Removed methods:
- WithWarnings.wrap
- WithWarnings.appendTo
- WithWarnings.append
    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    dd2655b View commit details
    Browse the repository at this point in the history

  5. Remove unused WithWarnings constructors

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a2ed4e5 View commit details
    Browse the repository at this point in the history

  6. Remove unused methods

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    267a22f View commit details
    Browse the repository at this point in the history

  7. Array.collectAllWarnings is not behind TruffleBoundary

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5f44b67 View commit details
    Browse the repository at this point in the history

  8. Make sure WarningsLibrary is correctly renamed in builtin method proc… 

    …essor
    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    eedbb1c View commit details
    Browse the repository at this point in the history

  9. Add specializations for a single warning to AppendWarningNode

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    47b06ac View commit details
    Browse the repository at this point in the history

  10. Warning.attach handles generic Object as value

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    68582bf View commit details
    Browse the repository at this point in the history

  11. ArrayRope implements InteropLibrary

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    737c472 View commit details
    Browse the repository at this point in the history

  12. Warning.get_all is implemented as dedicated node

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3f41e19 View commit details
    Browse the repository at this point in the history

  13. fmt

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2e78796 View commit details
    Browse the repository at this point in the history

  14. Fix typo in BuiltinMethod annotation

    @Akirathan
    Akirathan committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    06acf55 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Add specialization for Warning[] array to AppendWarningNode

    @Akirathan
    Akirathan committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e06e5fa View commit details
    Browse the repository at this point in the history

  2. Warning.set is implemented as a dedicated Node

    @Akirathan
    Akirathan committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c42592e View commit details
    Browse the repository at this point in the history

  3. Do not use uncached nodes at some places

    @Akirathan
    Akirathan committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    78bc3bc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'refs/heads/develop' into wip/akirathan/8682-with-warnin… 

    …gs-hashmap
    @Akirathan
    Akirathan committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f6f4ac0 View commit details
    Browse the repository at this point in the history

  5. fmt

    @Akirathan
    Akirathan committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b8b8308 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Warnings hash map have sequenceID as key

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5ab49d8 View commit details
    Browse the repository at this point in the history

  2. AppendWarningNode respects warnings limit

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    29d1748 View commit details
    Browse the repository at this point in the history

  3. Cannot insert null as hash map value

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2ca87e8 View commit details
    Browse the repository at this point in the history

  4. Add assert not null to method in WithWarnings

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c09460f View commit details
    Browse the repository at this point in the history

  5. When wrapping warnings, ensure that the previous warning are sorted

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a878626 View commit details
    Browse the repository at this point in the history

  6. Fix specializations in GetAllWarningsNode

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    456febc View commit details
    Browse the repository at this point in the history

  7. Fix specializations in SetWarningsNode

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    22eb44e View commit details
    Browse the repository at this point in the history

  8. Remove unused method

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e2d7a15 View commit details
    Browse the repository at this point in the history

  9. IsLimitReach is a dedicated node

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    61fbd7e View commit details
    Browse the repository at this point in the history

  10. SortVectorNode creates WithWarnings with specific limit

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    31c8e45 View commit details
    Browse the repository at this point in the history

  11. fmt

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    02bf7df View commit details
    Browse the repository at this point in the history

  12. profile in SetWarningsNode is shared

    @Akirathan
    Akirathan committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    56b8cee View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Fix specializations of AppendWarningNode. 

    They are now disjunct.
    @Akirathan
    Akirathan committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ed19e98 View commit details
    Browse the repository at this point in the history

  2. Warnings test is executed in context. 

    Because it executes nodes.
    @Akirathan
    Akirathan committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b098f07 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refs/heads/develop' into wip/akirathan/8682-with-warnin… 

    …gs-hashmap

# Conflicts:
#	engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/ordering/SortVectorNode.java
    @Akirathan
    Akirathan committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    788115f View commit details
    Browse the repository at this point in the history

  4. Ensure Array.sort is not on fast-path. 

    This fixes native image build.
    @Akirathan
    Akirathan committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    07b9d9f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Remove reassignments from Warning

    @Akirathan
    Akirathan committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7199733 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. WarningsLibrary.getWarnings returns reference to EnsoHashMap, not an … 

    …array.

This should avoid unnecessary new array allocations.
    @Akirathan
    Akirathan committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3884099 View commit details
    Browse the repository at this point in the history

  2. Use HashMapInsertAllNode to concat two hash maps. 

    Avoid materializing entries vector for them.
    @Akirathan
    Akirathan committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    c2815e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. HashMapInsertAll creates builder directly

    @Akirathan
    Akirathan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f91791d View commit details
    Browse the repository at this point in the history

  2. Transfer to interpreter before throwing an exception

    @Akirathan
    Akirathan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0a7e04f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. EnsoHashMap has iterator

    @Akirathan
    Akirathan committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cda8ef9 View commit details
    Browse the repository at this point in the history

  2. slow conversion from array to map calls CompilerAsserts.neverPartOfCo… 

    …mpilation
    @Akirathan
    Akirathan committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4fb72b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. javafmt

    @JaroslavTulach
    JaroslavTulach committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    143e5f8 View commit details
    Browse the repository at this point in the history

  2. Avoid Arrays.copyOf in the IGV as vectorFromFunction always knows the… 

    … right size
    @JaroslavTulach
    JaroslavTulach committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9823d2c View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. CompilationFailureAction=Print is only useful when we enable logging

    @JaroslavTulach
    JaroslavTulach committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    af7ac69 View commit details
    Browse the repository at this point in the history

  2. javafmt

    @JaroslavTulach
    JaroslavTulach committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    05c205b View commit details
    Browse the repository at this point in the history

  3. Avoid recursive call in TypeOfNode.doWarning

    @JaroslavTulach
    JaroslavTulach committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    f46b26b View commit details
    Browse the repository at this point in the history

  4. Generate two source files: one for setup and other for benchmarking

    @JaroslavTulach
    JaroslavTulach committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    7e6a053 View commit details
    Browse the repository at this point in the history

  5. Don't inline setup code

    @JaroslavTulach
    JaroslavTulach committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6ebc286 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Warnings in builtin methods are collected via WarningsLibrary

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    4005fe6 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary conversion to Warning[] array

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    01381e6 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary usages of ArrayRope

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1d9170c View commit details
    Browse the repository at this point in the history

  4. Remove ArrayRope

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1266cbd View commit details
    Browse the repository at this point in the history

  5. fmt

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8b6dd89 View commit details
    Browse the repository at this point in the history

  6. Remove direct reference to generated node

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    82f8506 View commit details
    Browse the repository at this point in the history

  7. Rename AppendWarningNode.execute to executeAppend

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    5003a91 View commit details
    Browse the repository at this point in the history

  8. Cast long to int to not crash the interpreter

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    900b091 View commit details
    Browse the repository at this point in the history

  9. fix typo in MethodProcessor

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    9d732a9 View commit details
    Browse the repository at this point in the history

  10. Replace CompilerAsserts.neverPartOfCompilation with TruffleBoundary

    @Akirathan
    Akirathan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1629773 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. tests in interpreter-dsl-test enter polyglot context

    @Akirathan
    Akirathan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d09f0ce View commit details
    Browse the repository at this point in the history

  2. Methods in EnsoHashMapBuilder are package-protected

    @Akirathan
    Akirathan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    39f7262 View commit details
    Browse the repository at this point in the history

  3. TailCallException stores warnings as EnsoHashMap

    @Akirathan
    Akirathan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e887db5 View commit details
    Browse the repository at this point in the history

  4. Make EnsoHashMap.getCachedVectorRepresentation methods package-protected

    @Akirathan
    Akirathan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2d7a8b3 View commit details
    Browse the repository at this point in the history

  5. EnsoHashMap.getHashSize is package-protected. 

    Hash size is fetched via HashMapSizeNode.
    @Akirathan
    Akirathan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0ecab16 View commit details
    Browse the repository at this point in the history

  6. fmt

    @Akirathan
    Akirathan committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a5878b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. EntriesIterator is final

    @Akirathan
    Akirathan committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a44cf5a View commit details
    Browse the repository at this point in the history

  2. Use EnsoHashMap for warnings instead of an array.

    @Akirathan
    Akirathan committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a88ae74 View commit details
    Browse the repository at this point in the history

  3. Change signature of HashMapInsertAllNode to accept only EnsoHashMaps

    @Akirathan
    Akirathan committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ac6dfb4 View commit details
    Browse the repository at this point in the history