Speeding up Ordering_Comparator #10593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
hubertp and
Akirathan
as code owners
radeusgd
reviewed
Jul 18, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Internal/Ordering_Helpers.enso
Show resolved
Hide resolved
radeusgd
approved these changes
Jul 18, 2024
hubertp
approved these changes
Jul 18, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10539 by implementing the
Ordering_Comparator.comparewithout delegating toto_sign- that would require another comparator and would slow things down.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
Max_Stats) are faster: benchmarks run