Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package libraries Java code as Java Modules #10714

Draft
wants to merge 90 commits into
base: develop
Choose a base branch
from
Draft

Package libraries Java code as Java Modules #10714

wants to merge 90 commits into from

Commits on Jul 29, 2024

  1. Must specify --repl to enable debug server

    @JaroslavTulach
    JaroslavTulach committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9c149b9 View commit details
    Browse the repository at this point in the history

  2. Use --repl to enable REPL changelog note

    @JaroslavTulach
    JaroslavTulach committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    76070ba View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Towards a ClassPath per Package

    @JaroslavTulach
    JaroslavTulach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    873c418 View commit details
    Browse the repository at this point in the history

  2. One ClassLoader per each Package

    @JaroslavTulach
    JaroslavTulach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3b1bc98 View commit details
    Browse the repository at this point in the history

  3. Define ModuleLayer for each Package

    @JaroslavTulach
    JaroslavTulach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    45f62cf View commit details
    Browse the repository at this point in the history

  4. Load classes via ModuleLayer

    @JaroslavTulach
    JaroslavTulach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8700cc8 View commit details
    Browse the repository at this point in the history

  5. Turning std-base and std-aws into Java modules

    @JaroslavTulach
    JaroslavTulach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    74f8111 View commit details
    Browse the repository at this point in the history

  6. Turn common-polyglot-core-utils into JPMS module

    @Akirathan
    Akirathan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7e865ce View commit details
    Browse the repository at this point in the history

  7. Add depedencies to org.enso.std.base JPMS module

    @Akirathan
    Akirathan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3a6c335 View commit details
    Browse the repository at this point in the history

  8. Turn std-database into JPMS module

    @Akirathan
    Akirathan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b23be3d View commit details
    Browse the repository at this point in the history

  9. Add depedencies to org.enso.std.aws JPMS module

    @Akirathan
    Akirathan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f0dd3f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Using module-info to register SPI services

    @JaroslavTulach
    JaroslavTulach committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c4c1842 View commit details
    Browse the repository at this point in the history

  2. Removing another no longer needed dependency on NetBeans Lookup API

    @JaroslavTulach
    JaroslavTulach committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    149dc7e View commit details
    Browse the repository at this point in the history

  3. Removing add to class path concept

    @JaroslavTulach
    JaroslavTulach committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    48b29c7 View commit details
    Browse the repository at this point in the history

  4. Turn std-table into JPMS module

    @Akirathan
    Akirathan committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    dd5723e View commit details
    Browse the repository at this point in the history

  5. Move tests that need internal access to Standard.Base into test/Base_… 

    …Internal_Tests
    @JaroslavTulach
    JaroslavTulach committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    74fa9e1 View commit details
    Browse the repository at this point in the history

  6. Resolving merge conficts

    @JaroslavTulach
    JaroslavTulach committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1e48979 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. No more of Polyglot.Java

    @JaroslavTulach
    JaroslavTulach committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bbe754c View commit details
    Browse the repository at this point in the history

  2. Nicer formatting with var

    @JaroslavTulach
    JaroslavTulach committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1514ad2 View commit details
    Browse the repository at this point in the history

  3. Allow Standard.Table to depend on modules from Standard.Base

    @JaroslavTulach
    JaroslavTulach committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    09c6946 View commit details
    Browse the repository at this point in the history

  4. language-server/test compiles again

    @JaroslavTulach
    JaroslavTulach committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3148976 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Host Files values group_builder

    @JaroslavTulach
    JaroslavTulach committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ae64b8a View commit details
    Browse the repository at this point in the history

  2. Merging in develop branch

    @JaroslavTulach
    JaroslavTulach committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c5e41ab View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge with most recent develop branch that includes many JPMS

    @JaroslavTulach
    JaroslavTulach committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6fdd11c View commit details
    Browse the repository at this point in the history

  2. Using moduleDependencies and internalModuleDependencies for standard … 

    …libraries
    @JaroslavTulach
    JaroslavTulach committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cfdda7b View commit details
    Browse the repository at this point in the history

  3. There can be Enso sources without associated package

    @JaroslavTulach
    JaroslavTulach committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d50f006 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merging with develop

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    202b1d8 View commit details
    Browse the repository at this point in the history

  2. Avoid duplicated modules. Use the one from boot layer.

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b04ce5c View commit details
    Browse the repository at this point in the history

  3. Load all library Java modules with a single class loader

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d94a44d View commit details
    Browse the repository at this point in the history

  4. Opening std-table.jar for reflection from Enso code

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c71183c View commit details
    Browse the repository at this point in the history

  5. Visualization_Tests run and yield just nine errors

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9bc7a3a View commit details
    Browse the repository at this point in the history

  6. Standard.Test loads classes from Standard.Base

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    16b82c3 View commit details
    Browse the repository at this point in the history

  7. Always prefer modules from parent layers

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    405e88d View commit details
    Browse the repository at this point in the history

  8. AWS requires access to Standard.Base and Standard.Database JARs

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    57e64e0 View commit details
    Browse the repository at this point in the history

  9. Opening up std-table JAR, so Enso can access all Java classes

    @JaroslavTulach
    JaroslavTulach committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    efda30f View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Less functional boilerplate

    @JaroslavTulach
    JaroslavTulach committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e9a0456 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into wip/jtulach/ClassP… 

    …ath7082
    @JaroslavTulach
    JaroslavTulach committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c0359e2 View commit details
    Browse the repository at this point in the history

  3. Special Lookup class and registration via a property to allow searchi… 

    …ng all the available ModuleLayers
    @JaroslavTulach
    JaroslavTulach committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5b14f89 View commit details
    Browse the repository at this point in the history

  4. Turning Standard.Image into Java module

    @JaroslavTulach
    JaroslavTulach committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    841de5f View commit details
    Browse the repository at this point in the history

  5. Making test/Image_Tests pass OK

    @JaroslavTulach
    JaroslavTulach committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e6e5c09 View commit details
    Browse the repository at this point in the history

  6. Avoid DriverManager. Directly talk to Driver instances.

    @JaroslavTulach
    JaroslavTulach committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3194f6d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Register SQLServerConnectionDetailsSPI in std-bits/microsoft/*/module… 

    …-info.java
    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cbe625f View commit details
    Browse the repository at this point in the history

  2. No polyglot symbol for org.enso.base.encoding.NewlineDetector in Tabl… 

    …e_Tests fix
    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c72ab8e View commit details
    Browse the repository at this point in the history

  3. No polyglot symbol for org.enso.table.data.table.Table in Table_Tests

    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    062b26e View commit details
    Browse the repository at this point in the history

  4. No polyglot symbol for org.enso.table.data.table.join.between.SortedL… 

    …istIndex reported in Table_Tests
    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e4cc4b4 View commit details
    Browse the repository at this point in the history

  5. Using for loop

    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9c86f7a View commit details
    Browse the repository at this point in the history

  6. Make enso-test-java-helpers available to Table_Tests

    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6992103 View commit details
    Browse the repository at this point in the history

  7. No need to generate .bindings index to run benchmarks

    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    98eeb64 View commit details
    Browse the repository at this point in the history

  8. BenchProcessor puts runtime.jar into own layer. Use that one as bootL… 

    …ayer() when specified.
    @JaroslavTulach
    JaroslavTulach committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    60b4277 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. test/Benchmarks need access to org.enso.table.data.index.OrderedMulti… 

    …ValueKey
    @JaroslavTulach
    JaroslavTulach committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f482b72 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Introducing AWS wrapper module

    @JaroslavTulach
    JaroslavTulach committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3112158 View commit details
    Browse the repository at this point in the history

  2. Placeholders for exported packages

    @JaroslavTulach
    JaroslavTulach committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e51eb3e View commit details
    Browse the repository at this point in the history

  3. Remove placeholders

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a263449 View commit details
    Browse the repository at this point in the history

  4. Remove aws-wrapper/Compile/moduleDependencies. 

    They are not required - we don't want anything on module-path
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d161f9e View commit details
    Browse the repository at this point in the history

  5. javaModuleName is the first setting

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c03825c View commit details
    Browse the repository at this point in the history

  6. Fix typo in cbor library dependency

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    3ec8ed0 View commit details
    Browse the repository at this point in the history

  7. Typo in module name. 

    The module name in module-info.java must be the same as `javaModuleName` sbt setting.
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    41fd4c1 View commit details
    Browse the repository at this point in the history

  8. Fix compilation of aws-wrapper 

    - Patch all AWS modules
- Fix assemblyExcludedJars to remove all transitive dependencies
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4bec7d9 View commit details
    Browse the repository at this point in the history

  9. Remove empty settings from std-aws

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    88aaa76 View commit details
    Browse the repository at this point in the history

  10. Fix typo in module name

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    be66f1b View commit details
    Browse the repository at this point in the history

  11. aws-wrapper-assembly.jar gets into component directory.

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c97ec77 View commit details
    Browse the repository at this point in the history

  12. Remove signature from aws-wrapper-assembly jar

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4a6e55c View commit details
    Browse the repository at this point in the history

  13. aws-wrapper dependency of std-aws is "provided". 

    So there is just a single jar in AWS/polyglot/java directory
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    011494e View commit details
    Browse the repository at this point in the history

  14. Ensure aws-wrapper-assembly.jar gets into AWS/polyglot/java directory

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    92bc7b4 View commit details
    Browse the repository at this point in the history

  15. Fix NoSuchElementException in JPMSUtils

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    06ca5ce View commit details
    Browse the repository at this point in the history

  16. Revert "aws-wrapper-assembly.jar gets into component directory." 

    This reverts commit c97ec77.
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    34dda82 View commit details
    Browse the repository at this point in the history

  17. org.enso.std.aws exports org.enso.aws package

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e788644 View commit details
    Browse the repository at this point in the history

  18. slf4j is module dependency of aws-wrapper

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    644357d View commit details
    Browse the repository at this point in the history

  19. aws-wrapper depends on org.reactivestreams

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6c33fef View commit details
    Browse the repository at this point in the history

  20. aws-wrapper uses its own service. 

    Fixes ServiceConfigurationError.
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4c98a58 View commit details
    Browse the repository at this point in the history

  21. Add some dependencies to aws-wrapper

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e81e27c View commit details
    Browse the repository at this point in the history

  22. Add necessary exports

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    686f24d View commit details
    Browse the repository at this point in the history

  23. fmt

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c5b1959 View commit details
    Browse the repository at this point in the history

  24. FileSystemSPI uses Lookup instead of ServiceLoader

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2bd96d4 View commit details
    Browse the repository at this point in the history

  25. org.enso.std.aws provides DataLinkSPI. 

    And DataLinkSPI is implemented with Lookup instead of ServiceLoader.
    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    cf605cd View commit details
    Browse the repository at this point in the history

  26. Better error message on duplicated service providers

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    12ebe80 View commit details
    Browse the repository at this point in the history

  27. Duplicate provider is just a warning

    @Akirathan
    Akirathan committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a31fb9c View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. List is easier to == than Array

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    77dc8de View commit details
    Browse the repository at this point in the history

  2. runtime-integration-tests are loading classes with empty EnsoClassPath

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6388881 View commit details
    Browse the repository at this point in the history

  3. Java.lookup_class has been removed

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    00b47b4 View commit details
    Browse the repository at this point in the history

  4. Using List() at the right places

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4173822 View commit details
    Browse the repository at this point in the history

  5. std.table module isn't present in NI enso build

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f0c2ae4 View commit details
    Browse the repository at this point in the history

  6. Use Lookup to lookup DatabaseConnectionDetailsSPI

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    f11a26a View commit details
    Browse the repository at this point in the history

  7. An unexpected panic was thrown: (No_Such_Method.Error org.enso.base.n… 

    …et.http.UrlencodedBodyBuilder UnresolvedSymbol<new>)
    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b7f6542 View commit details
    Browse the repository at this point in the history

  8. Initialize ModuleLayer for a library sooner than a class is loaded fr… 

    …om it
    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    baeff36 View commit details
    Browse the repository at this point in the history

  9. There is no runtime-fat-jar anymore

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a9bc32f View commit details
    Browse the repository at this point in the history

  10. Add JDK_MODULES to small JDK of engine-runner native image

    @Akirathan
    Akirathan committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ec03e10 View commit details
    Browse the repository at this point in the history

  11. Catch also ResolutionException

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1d4b172 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Always add at least boot layer as parent

    @JaroslavTulach
    JaroslavTulach committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2bf4df1 View commit details
    Browse the repository at this point in the history

  2. Make Tableau_Tests pass

    @JaroslavTulach
    JaroslavTulach committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e8c220b View commit details
    Browse the repository at this point in the history