Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attaching a warning to error is no op #10765

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Attaching a warning to error is no op #10765

merged 1 commit into from
Aug 9, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Aug 6, 2024 •
edited
Loading

Pull Request Description

Fixes #10736 by avoiding attaching of warnings to DataflowErrors.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Aug 6, 2024
@JaroslavTulach JaroslavTulach self-assigned this Aug 6, 2024
@enso-bot enso-bot bot mentioned this pull request Aug 7, 2024
Open
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Aug 7, 2024 •
edited
Loading

Looks like we have a failure when executing test/Base_Tests:

java.lang.AssertionError: Cannot attach warnings to Error Error:Already_Exists (Value (File C:\runner\_work\enso\enso\test\Base_Tests\data\transient\work.txt))

apparently we are trying to attach a warning to an error. Fixed in 843c893 - all paths that construct WithWarnings need to check for DataflowError now.

@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Aug 7, 2024
Akirathan
Akirathan reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until #10555 is merged. I am afraid you will have to re-implement it from scratch then. You will have to change the implementation of AppendWarningNode.

@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/CannotAttachWarningToError branch from 412c623 to 0e03d15 Compare August 8, 2024 06:54
@JaroslavTulach
Copy link
Member Author

... you will have to re-implement it from scratch then.

Re-implemented from scratch in 0e03d15

@JaroslavTulach JaroslavTulach merged commit 8de4b8c into develop Aug 9, 2024
40 of 41 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/CannotAttachWarningToError branch August 9, 2024 08:39
@JaroslavTulach JaroslavTulach mentioned this pull request Aug 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicit return type with error causes type error when an error is thrown
3 participants
@JaroslavTulach @Akirathan @GregoryTravis