Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chrome devtools and DAP tools for debugging #8344

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Nov 20, 2023

Fixes #8314

Pull Request Description

Adds chrome-inspector tool and Debug Adapter protocol tool for debugging Enso.

Important Notes

The chrome devtools seems to be broken (tracked in oracle/graal#7636). Even graalpy --inspect ... fails (Chrome devtools freezes after connecting to the server). This PR adds Debug adapter protocol tool for debugging as a workaround for chrome inspector. There is docs in dap.md

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 20, 2023
@Akirathan Akirathan self-assigned this Nov 20, 2023
@Akirathan
Copy link
Member Author

Akirathan commented Nov 20, 2023

DAP works just fine:

image

cc @GregoryTravis : you can use this instead of --inspect (once this is merged obviously)

@Akirathan Akirathan changed the title Add chromeinspector tool to components dir Add Chrome devtools and DAP tools for debugging Nov 20, 2023
docs/debugger/dap.md Outdated Show resolved Hide resolved
The behavior of step over changed, but it is still usable.
@Akirathan Akirathan linked an issue Nov 20, 2023 that may be closed by this pull request
docs/debugger/dap.md Outdated Show resolved Hide resolved
@enso-bot enso-bot bot mentioned this pull request Nov 20, 2023
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the documentation to talk about VSCode setup in the Enso repository.

Akirathan and others added 2 commits November 21, 2023 09:48
Show an example of full `launch.json`

Co-authored-by: Radosław Waśko <[email protected]>
@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Nov 22, 2023
@Akirathan Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Nov 22, 2023
@mergify mergify bot merged commit 268e595 into develop Nov 22, 2023
31 of 34 checks passed
@mergify mergify bot deleted the wip/akirathan/8314-add-chromeinspector branch November 22, 2023 17:18
@enso-bot enso-bot bot mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chromeinspector tool
3 participants