Towards simplifying runtime-compiler dependencies
#8894
Conversation
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
|
We need to solve the serialization manager issue. Thinking about it, it looks like the best way to solve it is to rewrite caching as requested by and remember that a single |
build.sbt
Outdated
| .dependsOn(`runtime-instrument-repl-debugger`) | ||
| .dependsOn(`runtime-instrument-runtime-server`) | ||
| .dependsOn(`runtime-language-epb`) | ||
| .dependsOn(LocalProject("runtime-instrument-common")) |
There was a problem hiding this comment.
Originally, I have rewritten runtime to LocalProject("runtime"), because sbt was giving me some error. Is this a similar case? If not, let's rather stick with the backtick notation - that gives me navigation capabilities in my IDE.
There was a problem hiding this comment.
It is the same case. A cyclic reference between lazy val projects.
I tend to believe we should move integration tests from runtime to runtime-fat-jar project and avoid these vicious circles of project dependencies...
JaroslavTulach
changed the title
runtime-compiler dependencies on Jacksonruntime-compiler dependencies on Jackson
JaroslavTulach
added
the
CI: Clean build required
JaroslavTulach
changed the title
runtime-compiler dependencies on Jacksonruntime-compiler dependencies on Jackson
JaroslavTulach
changed the title
runtime-compiler dependencies on Jacksonruntime-compiler dependencies
| @@ -578,9 +578,12 @@ private class DefaultPackageRepository( | |||
| val cache = ensurePackageIsLoaded(libraryName).toOption.flatMap { _ => | |||
| if (!loadedLibraryBindings.contains(libraryName)) { | |||
| loadedPackages.get(libraryName).flatten.foreach(loadDependencies(_)) | |||
| val cachedBindingOption = context | |||
| val cachedBindingOption = None | |||
| /* TBD: this has to be called somehow | |||
There was a problem hiding this comment.
@hubertp discovered this commented out piece of code. Thank you!
Pull Request Description
Initial step to address #8888. Splits
polyglot-api(which has inherent dependencies on Jackson) into two modules. One of them is calledengine-commonand has no dependencies on external libraries. Dependencies ofruntime*projects changed toengine-common.Not Part of this PR
The suggestion builder functionality has to go away from
engine/runtime. The idea is to create a new project calledruntime-suggestionsin one of the subsequent PRs. Such a change is left out from the PR to keep it smaller, and to minimize conflicts during merging. There is serialization manager issue to be solved.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,