Minor follow up to #9528 #9841
Merged
Minor follow up to #9528 #9841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
added
the
CI: No changelog needed
Addressing some PR comments, DRY.
hubertp
force-pushed
the
wip/hubert/ydoc-nits
branch
from
6ef0821
to
2fbfecb
Compare
JaroslavTulach
approved these changes
May 2, 2024
lib/java/ydoc-server/src/main/java/org/enso/ydoc/polyfill/PolyfillBase.java
Outdated
Show resolved
Hide resolved
lib/java/ydoc-server/src/main/java/org/enso/ydoc/polyfill/PolyfillBase.java
Outdated
Show resolved
Hide resolved
Akirathan
approved these changes
May 3, 2024
lib/java/ydoc-server/src/test/java/org/enso/ydoc/polyfill/web/WebSocketServerTest.java
Outdated
Show resolved
Hide resolved
4e6
approved these changes
May 6, 2024
| try (var executor = Executors.newSingleThreadExecutor(); | ||
| var parser = new ParserPolyfill()) { | ||
| // Can't use try-with-resource in ExecutorService because API was added in JDK19 | ||
| var executor = Executors.newSingleThreadExecutor(); |
There was a problem hiding this comment.
oh, wow, I wonder why the compiler was not complaining before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
While playing with the implementation addressed some PR comments of mine and applied DRY.