bazel: Allow multiple definitions for armeabi android links #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on rust support we hit this issue rust-lang/compiler-builtins#353 which seems to still be persistent even in the case you have the nightly version mentioned there. I haven't been able to reproduce the issue in a separate project, but the core seems to be that both libgcc and rust's compiler builtins module vendor some float math symbols and both are included. This change is as scoped as possible so that no real issues could sneak in with this disabled, which should mostly be covered by only passing this for the single arch. Signed-off-by: Keith Smiley <[email protected]>
snowp
approved these changes
Apr 13, 2022
keith
deleted the
ks/bazel-allow-multiple-definitions-for-armeabi-android-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on rust support we hit this issue
rust-lang/compiler-builtins#353 which seems to
still be persistent even in the case you have the nightly version
mentioned there. I haven't been able to reproduce the issue in a
separate project, but the core seems to be that both libgcc and rust's
compiler builtins module vendor some float math symbols and both are
included. This change is as scoped as possible so that no real issues
could sneak in with this disabled, which should mostly be covered by
only passing this for the single arch.
Signed-off-by: Keith Smiley [email protected]