jni: introduce custom find_class method #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: Rafal Augustyniak <[email protected]>
|
/retest |
Signed-off-by: Rafal Augustyniak <[email protected]>
snowp
previously approved these changes
Aug 19, 2022
| * defined by the project. For finding classes of Java built in-types use | ||
| * `env->FindClass(...)` method instead as it is lighter to use. | ||
| * | ||
| * @param class_name, the name of the class to find (i.e. "org.chromium.net.AndroidNetworkLibrary"). |
There was a problem hiding this comment.
its / delimited, not . right?
There was a problem hiding this comment.
It requires . - I added an example to avoid confusion since I realize that / would be a more obvious choice here.
There was a problem hiding this comment.
oh i see, you're calling loadClass and not findClass
nice consistency java
Signed-off-by: Rafal Augustyniak <[email protected]>
Good idea, updated. |
Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
approved these changes
Aug 19, 2022
RyanTheOptimist
approved these changes
Aug 19, 2022
|
/retest |
Augustyniak
added a commit
that referenced
this pull request
Aug 30, 2022
Description: Update the implementation of `Java_io_envoyproxy_envoymobile_engine_AndroidJniLibrary_initialize` so that it takes a `class_loader` argument which was introduced in #2483. It turns out that this method is implemented in two separate places - `android_jni_interface.cc` and and `android_test_jni_interface.cc` files - and my previous PR updated only the former. This is needed to make `find_class` method work in tests as tests depend on the implementation from `android_test_jni_interface.cc` file. Risk Level: None, additive change for test targets only. Testing: None, a follow up tests that depend on `find_class` method are being worked on. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: Update the implementation of `Java_io_envoyproxy_envoymobile_engine_AndroidJniLibrary_initialize` so that it takes a `class_loader` argument which was introduced in envoyproxy/envoy-mobile#2483. It turns out that this method is implemented in two separate places - `android_jni_interface.cc` and and `android_test_jni_interface.cc` files - and my previous PR updated only the former. This is needed to make `find_class` method work in tests as tests depend on the implementation from `android_test_jni_interface.cc` file. Risk Level: None, additive change for test targets only. Testing: None, a follow up tests that depend on `find_class` method are being worked on. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The change is needed in order for JNI to be able to find classes which are defined in our repository (as opposed to built in Java types). Google documents in here touches on this issue. The implementation could be improved by adding some caching to it but I am inclined to keep it simple unless we find out that its performance is an issue. Needed for #2432.
Risk Level: None, not used anywhere as of now.
Testing: Manual
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Rafal Augustyniak [email protected]