Latest solidity support #393

mstad · 2020-05-11T07:50:20Z

Hi,
is the last solidity supported 0.4.24? (I tried to compile contract using 0.5.x release and I receive an error). Is there a way to overcome these limitations?

yxliang01 · 2020-05-11T08:15:51Z

Hi @mstad , the latest official supported version is indeed 0.4 . It would be great if you can post 1. the minimum contract written in Solidity 0.5 that can't be run 2. the error you received here. Then, we can try to see how to overcome these.

mstad · 2020-05-11T16:43:44Z

Hi @yxliang01, as soon as I tried to analyze a contract (the contract has the pragma >0.5.0, and the solc that I have installed is the 0.5.15 release), I receive the error of 'compilation failed.' Analyzing it with -ce option, I receive the comment that the last supported solc release is 0.4.19.
I try to use the prebuild docker container and to build a new one from Github. Have I to try something different?

yxliang01 · 2020-05-11T16:55:17Z

No, the message of the officially supported version is not an error. Would be great if you can paste the contract and the full output log here.

mstad · 2020-05-11T20:07:40Z

The output is

WARNING:root:You are using an untested version of z3. 4.5.1 is the officially tested version
WARNING:root:You are using evm version 1.9.9. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
CRITICAL:root:Warning: This is a pre-release compiler version, please do not use it in production.

CRITICAL:root:Solidity compilation failed.

The file is:

pragma solidity >=0.5.0 < 0.6.0;

contract Ownable {
address public owner;

constructor () public {
    owner = msg.sender;
}

modifier onlyOwner() {
    require(msg.sender == owner);
    _;
}

function transferOwnership(address newOwner) public onlyOwner {
    if (newOwner != address(0)) {
        owner = newOwner;
    }
}

}

Note that I am using the Oyente build just-now; using the prebuild docker oyente, I had only this lines as warnings and errors:

WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
CRITICAL:root:Warning: This is a pre-release compiler version, please do not use it in production.

CRITICAL:root:Solidity compilation failed.

Thanks

yxliang01 · 2020-05-12T08:27:06Z

@mstad Would you like to

Build a new docker image from this master branch
Use the -ce flag to see the error messages
?

mstad · 2020-05-13T08:02:44Z

Hi, sorry for the delay.

I build oyente docker container from the master branch as oyente.

Now, I am trying to using it sharing the directory in which I have some contract, but it retunr that it
does not find any file. Where I made a (for sure stupid) mistake?

docker run -it -v /home/.../simple_contracts/:/share oyente /share/myContract.sol -ce

CRITICAL:root:Skipping non-existent input file ""/share/myContract_0.5.15.sol""

CRITICAL:root:Solidity compilation failed.

yxliang01 · 2020-05-13T08:17:18Z

Why is the supplied path in docker run command is different from the one in error message?

mstad · 2020-05-13T15:31:43Z

The error message reports the path that in my intention was shared in the container... but I made a mistake, I think...

yxliang01 · 2020-05-13T15:37:34Z

@mstad I meant that the error message doesn't seem to correspond to the command you have pasted.

mstad · 2020-05-13T18:08:33Z

@yxliang01

you are totally right, I put the wrong filename... Inserting the right command, I receive an error

related to constructor. I attach the command, the error and the file. Thanks so much.

docker run -it -v /home/mirkostad/Programmi/perl/simple_contracts/:/share oyente -s /share/my.sol -ce

CRITICAL:root:/share/my.sol:7:16: Error: Expected identifier, got 'LParen'
constructor() public {
^

CRITICAL:root:Solidity compilation failed.

my.sol

pragma solidity >=0.5.0 < 0.6.0;

contract MyContract {

address owner;

constructor() public {
    owner = msg.sender;
}

function sendTo(address payable receiver, uint amount) public {
    require(tx.origin == owner);
    receiver.transfer(amount);
}

}

yxliang01 · 2020-05-13T18:19:15Z

@mstad I believe you are using the old solc 0.4.19 since it's the default version specified in the dockerfile. Therefore, it makes sense that it doesn't recognize the constructor keyword (added in 0.4.23) .

Would you like to simply try to use the latest 0.5 solc and see whether it works? A quick way is that you add --build-arg SOLC_VERSION=0.5.17 to the docker build command, and it might work straightaway.

P.S. You might want to care the comment formatting a bit :)

mstad · 2020-05-13T19:45:53Z

@yxliang01 I'll try to rebuild it now and I let you know asap. You are right for the formatting...

mstad · 2020-05-14T04:56:58Z

Hi, I tries to build the docker from master using:
$ docker build --build-arg SOLC_VERSION=0.5.15 -t oyente .
Then I launched Oyente and this is the output:
$ docker run -it -v /home/mirkostad/Programmi/perl/simple_contracts/:/share oyente -s /share/my.sol -ce
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
CRITICAL:root:
CRITICAL:root:Solidity compilation failed.

yxliang01 · 2020-05-14T08:09:30Z

@mstad Looks like the error might be in the stdout. I have just added stdout output of solc when compilation failed. Could you pull the latest master and build again, then run in the same manner?

mstad · 2020-05-14T09:43:25Z

@yxliang01 I'll do it now.

mstad · 2020-05-14T10:48:22Z

Hi, i'll tried and I received this output:
docker run -it -v /home/mirkostad/Programmi/perl/simple_contracts/:/share oyente -s /share/my.sol -ce
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
CRITICAL:root:solc output:

======= /share/my.sol:MyContract =======
Binary of the runtime part:
608060405234801561001057600080fd5b506004361061002b5760003560e01c80639e1a00aa14610030575b600080fd5b61007c6004803603604081101561004657600080fd5b81019080803573ffffffffffffffffffffffffffffffffffffffff1690602001909291908035906020019092919050505061007e565b005b6000809054906101000a900473ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff163273ffffffffffffffffffffffffffffffffffffffff16146100d757600080fd5b8173ffffffffffffffffffffffffffffffffffffffff166108fc829081150290604051600060405180830381858888f1935050505015801561011d573d6000803e3d6000fd5b50505056fea265627a7a723158206396e1cca8bf7327e62560d3816ad8bb68800c0a198ab8d2dad3f37c7b3b0e6d64736f6c634300050f0032

CRITICAL:root:
CRITICAL:root:Solidity compilation failed.

yxliang01 · 2020-05-14T16:47:12Z

@mstad the compilation succeeded, this means that it is the logic to extract the binary code is not supporting the new solc. Would you like to try branch fix-new-solc and see whether it works?

mstad · 2020-05-15T18:15:35Z

@yxliang01 Yes, I would try to do it.

mstad · 2020-05-16T22:11:32Z

@yxliang01 I build the container from fix-new-solc branch:
$ docker build --build-arg SOLC_VERSION=0.5.15 -t oyente .
I receive the following output:
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Original/:/share oyente_mod:latest -s /share/0x1c_fixed.sol -ce
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
incomplete push instruction at 134
incomplete push instruction at 1318
incomplete push instruction at 60
Traceback (most recent call last):
File "/oyente/oyente/oyente.py", line 222, in
main()
File "/oyente/oyente/oyente.py", line 217, in main
exit_code = analyze_solidity()
File "/oyente/oyente/oyente.py", line 109, in analyze_solidity
inputs = helper.get_inputs()
File "/oyente/oyente/input_helper.py", line 75, in get_inputs
source_map = SourceMap(contract, self.source, 'solidity', self.root_path, self.remap, self.allow_paths)
File "/oyente/oyente/source_map.py", line 50, in init
self.source = self._get_source()
File "/oyente/oyente/source_map.py", line 139, in _get_source
SourceMap.sources[fname] = Source(fname)
File "/oyente/oyente/source_map.py", line 14, in init
self.content = self._load_content()
File "/oyente/oyente/source_map.py", line 19, in _load_content
content = f.read()
File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 83: ordinal not in range(128)
with the file
0x1c_fixed.txt
I do not know if I can try something different to try to use it with 0.5.x or it is not possible,

yxliang01 · 2020-05-17T07:48:25Z

@mstad Thanks again for testing. Looks like the previous patch fixed the compilation result passing problem which means we have made one step forward! According to this error message, I have just pushed new patch to branch fix-new-solc, would you like to try it again with this contract?

mstad · 2020-05-18T09:20:57Z

@yxliang01 Hi,i tried to use the fix-new-solc branch. I build the new container and tried the same contract. The analysis is not complete, but the output is slighlty different than before:
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Original/:/share oyente_mod:latest -s /share/0x1c_fixed.sol -ce
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
incomplete push instruction at 134
incomplete push instruction at 1318
incomplete push instruction at 60
INFO:root:contract /share/0x1c_fixed.sol:ACL:
INFO:symExec: ============ Results ===========
Traceback (most recent call last):
File "/oyente/oyente/oyente.py", line 222, in
main()
File "/oyente/oyente/oyente.py", line 217, in main
exit_code = analyze_solidity()
File "/oyente/oyente/oyente.py", line 110, in analyze_solidity
results, exit_code = run_solidity_analysis(inputs)
File "/oyente/oyente/oyente.py", line 87, in run_solidity_analysis
result, return_code = symExec.run(disasm_file=inp['disasm_file'], source_map=inp['source_map'], source_file=inp['source'])
File "/oyente/oyente/symExec.py", line 2458, in run
analyze()
File "/oyente/oyente/symExec.py", line 2441, in analyze
run_build_cfg_and_analyze(timeout_cb=timeout_cb)
File "/oyente/oyente/symExec.py", line 2398, in run_build_cfg_and_analyze
build_cfg_and_analyze()
File "/oyente/oyente/symExec.py", line 225, in build_cfg_and_analyze
collect_vertices(tokens)
File "/oyente/oyente/symExec.py", line 341, in collect_vertices
idx = mapping_non_push_instruction(current_line_content, current_ins_address, idx, positions, length) if g_src_map else None
File "/oyente/oyente/symExec.py", line 281, in mapping_non_push_instruction
raise Exception("Source map error")
Exception: Source map error

yxliang01 · 2020-05-18T09:28:21Z

@mstad This means we moved one step again! I've made a new commit to the branch to print more information message for addressing this issue.

mstad · 2020-05-18T10:41:51Z

@yxliang01 Hi, i put here the new error message from the same file.
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Original/:/share oyente_mod:latest -s /share/0x1c_fixed.sol -ce
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
incomplete push instruction at 134
incomplete push instruction at 1318
incomplete push instruction at 60
INFO:root:contract /share/0x1c_fixed.sol:ACL:
INFO:symExec: ============ Results ===========
Traceback (most recent call last):
File "/oyente/oyente/oyente.py", line 222, in
main()
File "/oyente/oyente/oyente.py", line 217, in main
exit_code = analyze_solidity()
File "/oyente/oyente/oyente.py", line 110, in analyze_solidity
results, exit_code = run_solidity_analysis(inputs)
File "/oyente/oyente/oyente.py", line 87, in run_solidity_analysis
result, return_code = symExec.run(disasm_file=inp['disasm_file'], source_map=inp['source_map'], source_file=inp['source'])
File "/oyente/oyente/symExec.py", line 2458, in run
analyze()
File "/oyente/oyente/symExec.py", line 2441, in analyze
run_build_cfg_and_analyze(timeout_cb=timeout_cb)
File "/oyente/oyente/symExec.py", line 2398, in run_build_cfg_and_analyze
build_cfg_and_analyze()
File "/oyente/oyente/symExec.py", line 225, in build_cfg_and_analyze
collect_vertices(tokens)
File "/oyente/oyente/symExec.py", line 341, in collect_vertices
idx = mapping_non_push_instruction(current_line_content, current_ins_address, idx, positions, length) if g_src_map else None
File "/oyente/oyente/symExec.py", line 281, in mapping_non_push_instruction
raise RuntimeError(F"Source map error, unknown name({name}) or instr_name({instr_name})")
RuntimeError: Source map error, unknown name(SHR) or instr_name(INVALID)

mstad · 2020-05-20T10:44:48Z

@yxliang01 Hi, do you have some news about it?

yxliang01 · 2020-05-20T17:18:04Z

Hi @mstad , I think I need more information. Can you run with --verbose option?

mstad · 2020-05-20T18:57:11Z

Hi, this are results with --verbose option; the file is attached.
0x1c_fixed.txt
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Original/:/share oyente_mod:latest -s /share/0x1c_fixed.sol --verbose
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
incomplete push instruction at 134
incomplete push instruction at 1318
incomplete push instruction at 60
INFO:root:contract /share/0x1c_fixed.sol:ACL:
INFO:symExec: ============ Results ===========
DEBUG:symExec:PUSH1 0x80
DEBUG:symExec:PUSH1 0x40
DEBUG:symExec:MSTORE
DEBUG:symExec:CALLVALUE
DEBUG:symExec:DUP1
DEBUG:symExec:ISZERO
DEBUG:symExec:PUSH2 0x0010
DEBUG:symExec:JUMPI
DEBUG:symExec:PUSH1 0x00
DEBUG:symExec:DUP1
DEBUG:symExec:REVERT
DEBUG:symExec:JUMPDEST
DEBUG:symExec:POP
DEBUG:symExec:PUSH1 0x04
DEBUG:symExec:CALLDATASIZE
DEBUG:symExec:LT
DEBUG:symExec:PUSH2 0x0093
DEBUG:symExec:JUMPI
DEBUG:symExec:PUSH1 0x00
DEBUG:symExec:CALLDATALOAD
DEBUG:symExec:PUSH1 0xe0
DEBUG:symExec:INVALID 0x1c
Traceback (most recent call last):
File "/oyente/oyente/oyente.py", line 222, in
main()
File "/oyente/oyente/oyente.py", line 217, in main
exit_code = analyze_solidity()
File "/oyente/oyente/oyente.py", line 110, in analyze_solidity
results, exit_code = run_solidity_analysis(inputs)
File "/oyente/oyente/oyente.py", line 87, in run_solidity_analysis
result, return_code = symExec.run(disasm_file=inp['disasm_file'], source_map=inp['source_map'], source_file=inp['source'])
File "/oyente/oyente/symExec.py", line 2458, in run
analyze()
File "/oyente/oyente/symExec.py", line 2441, in analyze
run_build_cfg_and_analyze(timeout_cb=timeout_cb)
File "/oyente/oyente/symExec.py", line 2398, in run_build_cfg_and_analyze
build_cfg_and_analyze()
File "/oyente/oyente/symExec.py", line 225, in build_cfg_and_analyze
collect_vertices(tokens)
File "/oyente/oyente/symExec.py", line 341, in collect_vertices
idx = mapping_non_push_instruction(current_line_content, current_ins_address, idx, positions, length) if g_src_map else None
File "/oyente/oyente/symExec.py", line 281, in mapping_non_push_instruction
raise RuntimeError(F"Source map error, unknown name({name}) or instr_name({instr_name})")
RuntimeError: Source map error, unknown name(SHR) or instr_name(INVALID)

yxliang01 · 2020-05-20T19:22:09Z

@mstad Thanks again.

So, I think this exposes the following issues:

your contract has opcode that is unsupported
evm version too low to understand the opcode
(potentially) parsing of new evm might be unsupported

To address them, we need to first try to build the image with --build-arg=ETHEREUM_VERSION=alltools-v1.9.14, then inspect the log.

mstad · 2020-05-20T20:45:57Z

@yxliang01 Hi build the branch with the following options:
docker build --build-arg SOLC_VERSION=0.5.15 --build-arg=ETHEREUM_VERSION=alltools-v1.9.14 -t oyente .
If this is correct... I have the following results (something seems changed)
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Original/:/share oyente:latest -s /share/0x1c_fixed.sol --verbose
WARNING:root:You are using evm version 1.9.14. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.15, The latest supported version is 0.4.19
incomplete push instruction at 134
incomplete push instruction at 1318
incomplete push instruction at 60
INFO:root:contract /share/0x1c_fixed.sol:ACL:
INFO:symExec: ============ Results ===========
DEBUG:symExec:PUSH1 0x80
DEBUG:symExec:PUSH1 0x40
DEBUG:symExec:MSTORE
DEBUG:symExec:CALLVALUE
DEBUG:symExec:DUP1
DEBUG:symExec:ISZERO
DEBUG:symExec:PUSH2 0x0010
DEBUG:symExec:b JUMPI
Traceback (most recent call last):
File "/oyente/oyente/oyente.py", line 222, in
main()
File "/oyente/oyente/oyente.py", line 217, in main
exit_code = analyze_solidity()
File "/oyente/oyente/oyente.py", line 110, in analyze_solidity
results, exit_code = run_solidity_analysis(inputs)
File "/oyente/oyente/oyente.py", line 87, in run_solidity_analysis
result, return_code = symExec.run(disasm_file=inp['disasm_file'], source_map=inp['source_map'], source_file=inp['source'])
File "/oyente/oyente/symExec.py", line 2458, in run
analyze()
File "/oyente/oyente/symExec.py", line 2441, in analyze
run_build_cfg_and_analyze(timeout_cb=timeout_cb)
File "/oyente/oyente/symExec.py", line 2398, in run_build_cfg_and_analyze
build_cfg_and_analyze()
File "/oyente/oyente/symExec.py", line 225, in build_cfg_and_analyze
collect_vertices(tokens)
File "/oyente/oyente/symExec.py", line 341, in collect_vertices
idx = mapping_non_push_instruction(current_line_content, current_ins_address, idx, positions, length) if g_src_map else None
File "/oyente/oyente/symExec.py", line 281, in mapping_non_push_instruction
raise RuntimeError(F"Source map error, unknown name({name}) or instr_name({instr_name})")
RuntimeError: Source map error, unknown name(JUMPI) or instr_name(b)

yxliang01 · 2020-05-21T12:51:09Z

@mstad Looks like the output format of evm indeed changed from 1.7.3 . I might need to dig into some documentation etc to understand the changes in format.

mstad · 2020-06-02T08:32:56Z

Hi @yxliang01, anything new?

mstad · 2020-06-09T15:08:58Z

Hi, let me know if I have well understood; I have compiled with:
$ docker build --build-arg SOLC_VERSION=0.4.24 --build-arg=ETHEREUM_VERSION=alltools-v1.7.3 -t oyente .
Obviously, processing the 0x1c.sol file, that uses sol 0.5.15, we have the following results:
$ docker run -it -v /home/mirkostad/Programmi/smart-contracts/Original/:/share oyente:latest -s /share/0x1c_fixed.sol -ce

WARNING:root:You are using solc version 0.4.24, The latest supported version is 0.4.19
CRITICAL:root:solc output:

CRITICAL:root:/share/0x1c_fixed.sol:90:32: Error: Expected ',' but got 'payable'
function withdrawEth(address payable _to) external;
^-----^

CRITICAL:root:Solidity compilation failed.

yxliang01 · 2020-06-09T19:22:39Z

@mstad This is a valid compilation error since address payable type is introduced in 0.5.0 while you were using 0.4.24 .

yxliang01 · 2020-06-09T19:24:30Z

What we are interested here is whether Oyente can now support solc newer than 0.4.19 in the new fix-new-solc branch. So, the test Solidity file should be written in manner supported by the corresponding version under testing.

mstad · 2020-06-09T21:37:40Z

@yxliang01 You mean between 0.4.19 and 0.4.24?

yxliang01 · 2020-06-10T14:30:05Z

@mstad sorry I think I don't get what you are asking.

mstad · 2020-06-10T15:40:28Z

@yxliang01 Sorry, I wrote half of the sentence. You mean that the test Solidity file should be written, in this test, in Solidity release 0.4.x; am I right?

yxliang01 · 2020-06-10T18:27:51Z

@mstad What I meant essentially is that the input Solidity file should be written for solc 0.4.24 when the SOLC_VERSION=0.4.24 . To address the previous compilation error, you can simply change the type from address payable to address .

mstad · 2020-06-15T11:07:34Z

@yxliang01
0x1c_fixed_04_24.sol.txt
firstResult.txt

First test:
$ docker build --build-arg SOLC_VERSION=0.4.24 --build-arg=ETHEREUM_VERSION=alltools-v1.7.3 -t oyente .
$ docker run -it -v /home/mirkostad/Programmi/smart-contracts/Oyente_modified/:/share oyente:latest -s /share/0x1c_fixed_04_24.sol -ce
0x1c_fixed_04_24.sol and results as attachment-> ok

mstad · 2020-06-15T12:08:26Z

@yxliang01
Second test:
$ docker build --build-arg SOLC_VERSION=0.4.19 --build-arg=ETHEREUM_VERSION=alltools-v1.8.0 -t oyente2 .
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Oyente_modified/:/share oyente:latest -s /share/0x1c_fixed_04_19.sol -ce >> secondResult.txt

0x1c_fixed_04_19.sol and secondResult.txt as attachment-> ok
secondResult.txt
0x1c_fixed_04_19.sol.txt

mstad · 2020-06-15T13:09:46Z

@yxliang01
Third test-> Nok
$ docker build --build-arg SOLC_VERSION=0.4.19 --build-arg=ETHEREUM_VERSION=alltools-v1.8.27 -t oyente3 .
$ docker run -it -v /home/mirkostad/Programmi/smart-contracts/Oyente_modified/:/share oyente3:latest -s /share/0x1c_fixed_04_19.sol -ce >> thirdResult.txt
thirdResilts as attachment-> Nok
thirdResult.txt
third_result_verbose.txt

yxliang01 · 2020-06-16T19:01:26Z

@mstad Nice! Looks like we can set the latest officially supported solc version to 0.4.24 after merging the branch fix-new-solc to master (will do in few days after reviewing carefully). The newer evm support is known to be up to version 1.8.0.

To better understand the supported solc versions, would you like to also try solc > 0.4.24 with evm == 1.8.0 to figure out the exact latest supported solc version?

By the way, just a small recommendation, maybe the results can be directly pasted here as code block, so that when others encounter errors, they might be able to find this issue by searching.

mstad · 2020-06-16T21:25:27Z

@yxliang01 Yes, I really would try. Tomorrow I use some other further version with evm both with 1.7.3 and 1.8.0 and we will see what happens. My impression is that the direct compatibility stops at 0.4.24 release but... only tests can speak definitively about it. If, in some way, it works with 0.5.0, my problems are solved. And.... yes, I insert code directly to help other users.

mstad · 2020-06-23T04:44:05Z

@yxliang01 I try to do the following
$ docker build --build-arg SOLC_VERSION=0.5.0 --build-arg=ETHEREUM_VERSION=alltools-v1.8.0 -t oyente5 .
$ docker run -it -v /home/mirkostad/Programmi/smart-contracts/Oyente_modified/:/share oyente5:latest -s /share/0x1c_fixed_0_5_0.sol -ce
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:solc output:

CRITICAL:root:
CRITICAL:root:Solidity compilation failed.

If I run oyente5 with the file created for 0.4.19...
docker run -it -v /home/mirkostad/Programmi/smart-contracts/Oyente_modified/:/share oyente5:latest -s /share/0x1c_fixed_04_19.sol -ce
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:solc output:

CRITICAL:root:/share/0x1c_fixed_04_19.sol:20:1: Error: Source file requires different compiler version (current compiler is 0.5.0+commit.1d4f565a.Linux.g++ - note that nightly builds are considered to be strictly less than the released version
pragma solidity 0.4.19;
^---------------------^
/share/0x1c_fixed_04_19.sol:276:5: Error: Functions are not allowed to have the same name as the contract. If you intend this to be a constructor, use "constructor(...) { ... }" to define it.
function Context () internal { }
^------------------------------^
/share/0x1c_fixed_04_19.sol:297:5: Error: Functions are not allowed to have the same name as the contract. If you intend this to be a constructor, use "constructor(...) { ... }" to define it.
function Ownable() internal {
^ (Relevant source part starts here and spans across multiple lines).
/share/0x1c_fixed_04_19.sol:636:3: Error: Functions are not allowed to have the same name as the contract. If you intend this to be a constructor, use "constructor(...) { ... }" to define it.
function PPDepositHolder(IPPGlobalRegistry _globalRegistry) public {
^ (Relevant source part starts here and spans across multiple lines).
/share/0x1c_fixed_04_19.sol:276:5: Warning: This declaration shadows an existing declaration.
function Context () internal { }
^------------------------------^
/share/0x1c_fixed_04_19.sol:273:1: The shadowed declaration is here:
contract Context {
^ (Relevant source part starts here and spans across multiple lines).

/share/0x1c_fixed_04_19.sol:297:5: Warning: This declaration shadows an existing declaration.
function Ownable() internal {
^ (Relevant source part starts here and spans across multiple lines).
/share/0x1c_fixed_04_19.sol:289:1: The shadowed declaration is here:
contract Ownable is Context {
^ (Relevant source part starts here and spans across multiple lines).

/share/0x1c_fixed_04_19.sol:636:3: Warning: This declaration shadows an existing declaration.
function PPDepositHolder(IPPGlobalRegistry _globalRegistry) public {
^ (Relevant source part starts here and spans across multiple lines).
/share/0x1c_fixed_04_19.sol:623:1: The shadowed declaration is here:
contract PPDepositHolder is IPPDepositHolder {
^ (Relevant source part starts here and spans across multiple lines).

/share/0x1c_fixed_04_19.sol:89:20: Error: Data location must be "calldata" for parameter in external function, but none was given.
function propose(bytes _data, string _dataLink) external ;
^---------^
/share/0x1c_fixed_04_19.sol:89:33: Error: Data location must be "calldata" for parameter in external function, but none was given.
function propose(bytes _data, string _dataLink) external ;
^--------------^
/share/0x1c_fixed_04_19.sol:92:25: Error: Data location must be "calldata" for parameter in external function, but none was given.
function fetchTokenId(bytes _data) external pure returns (uint256 tokenId);
^----------^

CRITICAL:root:Solidity compilation failed.

In your opinion.. is it possible that it works in some way for 0.5.x... or there is no way? In theory i will need... if in your opinion there is no way... I have to find another solution.

yxliang01 · 2020-06-24T19:57:35Z

Hi @mstad , supporting 0.5.x is definitely doable if not already supported. The second error is expected since the pragma specifies that only solc 0.4.19 can be used. What's interesting is the first error for which can potentially help us identify the problem. However, from your comment, it looks like solc didn't have any output nor error message. Would you like to execute solc in a oyente5 container and see whether it can compile? If not, paste the error message or whatever terminate output here.

mstad · 2020-06-25T09:29:46Z

Hi @yxliang01... How can I enter in the container without running oyente application?

yxliang01 · 2020-06-25T14:16:36Z

You can use --entrypoint=/bin/bash option, need to use it before the image name oyente5

mstad · 2020-06-25T16:23:58Z

@yxliang01
This is the output in the docker container:
root@b1e2b8cd763f:/oyente/oyente# python oyente.py -s /share/0x1c_fixed_0_5_0.sol
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:Solidity compilation failed. Please use -ce flag to see the detail.
root@b1e2b8cd763f:/oyente/oyente# python oyente.py -s /share/0x1c_fixed_0_5_0.sol -ce
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:solc output:

CRITICAL:root:
CRITICAL:root:Solidity compilation failed.
root@b1e2b8cd763f:/oyente/oyente# python oyente.py -s /share/0x1c_fixed_0_5_0.sol --verbose
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:Solidity compilation failed. Please use -ce flag to see the detail.

mstad · 2020-06-26T12:07:24Z

@yxliang01
The problem with python oyente.py -s /share/0x1c_fixed_0_5_0.sol was that the file has the pragma ^0.5.0 intead having pragma >=0.5.0; this error was not visualized as otuput.
Processing, into the docker container, some 0.5.x files, I was able to process without error 13 files of 15. As attachment the files that generates problems; following the related results:
--- > 0x3.sol
root@0e4cf47b6370:/oyente/oyente# python oyente.py -s /share/0x3.sol -ce
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:solc output:

CRITICAL:root:
CRITICAL:root:Solidity compilation failed.

---> 0xdb.sol
root@0e4cf47b6370:/oyente/oyente# python oyente.py -s /share/0xdb.sol -ce
WARNING:root:You are using evm version 1.8.0. The supported version is 1.7.3
WARNING:root:You are using solc version 0.5.0, The latest supported version is 0.4.19
CRITICAL:root:solc output:

CRITICAL:root:/share/0xdb.sol:186:5: Error: Overriding function visibility differs.
function notifyTokensReceived(address _from, uint _value) public {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:163:5: Overridden function is here:
function notifyTokensReceived(address _from, uint _value) external;
^-----------------------------------------------------------------^

/share/0xdb.sol:238:5: Error: Overriding function visibility differs.
function retrieveTokens(address _tokenContract) public {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:219:5: Overridden function is here:
function retrieveTokens(address _tokenContract) external;
^-------------------------------------------------------^

/share/0xdb.sol:419:5: Error: Overriding function visibility differs.
function transferOwnership(address _newOwner) public only_owner {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:398:5: Overridden function is here:
function transferOwnership(address _newOwner) external;
^-----------------------------------------------------^

/share/0xdb.sol:868:5: Error: Overriding function visibility differs.
function retrieveTokens(address _tokenContract) public only_owner not_accepted_token(_tokenContract) {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:219:5: Overridden function is here:
function retrieveTokens(address _tokenContract) external;
^-------------------------------------------------------^

/share/0xdb.sol:238:5: Error: Overriding function visibility differs.
function retrieveTokens(address _tokenContract) public {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:219:5: Overridden function is here:
function retrieveTokens(address _tokenContract) external;
^-------------------------------------------------------^

/share/0xdb.sol:419:5: Error: Overriding function visibility differs.
function transferOwnership(address _newOwner) public only_owner {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:398:5: Overridden function is here:
function transferOwnership(address _newOwner) external;
^-----------------------------------------------------^

/share/0xdb.sol:186:5: Error: Overriding function visibility differs.
function notifyTokensReceived(address _from, uint _value) public {
^ (Relevant source part starts here and spans across multiple lines).
/share/0xdb.sol:163:5: Overridden function is here:
function notifyTokensReceived(address _from, uint _value) external;
^-----------------------------------------------------------------^
CRITICAL:root:Solidity compilation failed.

0x3.txt
0xdb.txt

If I want to try to build a container using --build-arg SOLC_VERSION=0.5.15 which --build-arg=ETHEREUM_VERSION=alltools-v1.x.x. you suggest I can try?

yxliang01 · 2020-07-03T17:54:50Z

@mstad
Given your results, I think it is fair to say that the branch fix-new-solc supports solc up to 0.5.0

Regarding the two errors you have encountered, I need to see the solc output on 0x3.sol to know what happened. For 0xdb.sol, I believe it is a bug or version incompatibility in the contract source code itself.

I think you can try alltools-v1.8.1 first, then slowly raise the version (e.g. 1.8.2, 1.8.3...) until encountering errors.

mstad · 2020-07-18T08:32:45Z

@yxliang01 Sorry for the delay. I am intending to do it
Anyway, in some tests, it seems really that building with solc=0.5.0 option and tools=1.8.0 there are no problems at all.
I tried also with solc=0.5.4 and alltools=1.8.0 and I found that all worked, but I tested only some cases.
Anyway, I will report to you my results when I can newly try on it.

Mayur1496 · 2020-09-02T16:49:00Z

@yxliang01
Latest Solidity version supported : 0.5.4
Latest evm version supported : 1.8.16
Tested on :

Contract.sol

Output :

output

mstad · 2020-09-02T18:19:43Z

@Mayur1496 do you use the fix-new-solc branch?
The way to build the docker that you used is:
docker build --build-arg SOLC_VERSION=0.5.4 --build-arg=ETHEREUM_VERSION=alltools-v1.8.16 -t oyente ?

Mayur1496 · 2020-09-02T18:39:59Z

@mstad
I used the Full Installation method on fix-new-solc branch.
The docker build command that you mentioned seems correct to me :)

@mstad

After this PR, the latest known supported solc version is `0.5.4` with `evm` toolchain version `1.8.16`. Meanwhile, Solidity file containing non-ascii text will be supported. Thanks @mstad and @Mayur1496 for reporting and testing (in #393 ). Note that the version detection in Oyente is still unmodified as we plan to enhance the supported version detection later. This might be the first PR breaking python 2 support and partially support python > 3 and < 3.6.

taylorgag · 2020-10-15T06:48:08Z

Hi, sorry for the delay.

I build oyente docker container from the master branch as oyente.

Now, I am trying to using it sharing the directory in which I have some contract, but it retunr that it
does not find any file. Where I made a (for sure stupid) mistake?

docker run -it -v /home/.../simple_contracts/:/share oyente /share/myContract.sol -ce

CRITICAL:root:Skipping non-existent input file ""/share/myContract_0.5.15.sol""

CRITICAL:root:Solidity compilation failed.

sorry to bother you ,but how to build oyente docker container from the master branch as oyente?

yxliang01 · 2020-10-15T09:15:25Z

@taylorgag You can use the command docker build -t oyente . under the Oyente root directory. If you have further issues/questions, please open a new issue (instead of replying to this issue as this is considered off-topic).

mstad closed this as completed Jun 23, 2020

mstad reopened this Jun 23, 2020

This comment has been minimized.

Sign in to view

yxliang01 mentioned this issue Sep 4, 2020

feat: support new solc & UTF-8 #406

Merged

Latest solidity support #393

Latest solidity support #393

Comments

mstad commented May 11, 2020

yxliang01 commented May 11, 2020

mstad commented May 11, 2020 • edited Loading

yxliang01 commented May 11, 2020

mstad commented May 11, 2020

The output is

CRITICAL:root:Solidity compilation failed.

}

CRITICAL:root:Solidity compilation failed.

yxliang01 commented May 12, 2020

mstad commented May 13, 2020 • edited Loading

yxliang01 commented May 13, 2020

mstad commented May 13, 2020 • edited Loading

yxliang01 commented May 13, 2020

mstad commented May 13, 2020 • edited Loading

yxliang01 commented May 13, 2020

mstad commented May 13, 2020

mstad commented May 14, 2020

yxliang01 commented May 14, 2020

mstad commented May 14, 2020

mstad commented May 14, 2020

yxliang01 commented May 14, 2020

mstad commented May 15, 2020

mstad commented May 16, 2020

yxliang01 commented May 17, 2020

mstad commented May 18, 2020

yxliang01 commented May 18, 2020 • edited Loading

mstad commented May 18, 2020

mstad commented May 20, 2020

yxliang01 commented May 20, 2020

mstad commented May 20, 2020 • edited Loading

yxliang01 commented May 20, 2020

mstad commented May 20, 2020

yxliang01 commented May 21, 2020

mstad commented Jun 2, 2020

mstad commented Jun 9, 2020

yxliang01 commented Jun 9, 2020

yxliang01 commented Jun 9, 2020

mstad commented Jun 9, 2020

yxliang01 commented Jun 10, 2020

mstad commented Jun 10, 2020

yxliang01 commented Jun 10, 2020

mstad commented Jun 15, 2020

mstad commented Jun 15, 2020

mstad commented Jun 15, 2020 • edited Loading

yxliang01 commented Jun 16, 2020 • edited Loading

mstad commented Jun 16, 2020

mstad commented Jun 23, 2020

yxliang01 commented Jun 24, 2020

mstad commented Jun 25, 2020

yxliang01 commented Jun 25, 2020

mstad commented Jun 25, 2020

This comment has been minimized.

mstad commented Jun 26, 2020 • edited Loading

yxliang01 commented Jul 3, 2020

mstad commented Jul 18, 2020

Mayur1496 commented Sep 2, 2020

mstad commented Sep 2, 2020

Mayur1496 commented Sep 2, 2020

taylorgag commented Oct 15, 2020

yxliang01 commented Oct 15, 2020 • edited Loading

mstad commented May 11, 2020 •

edited

Loading

mstad commented May 13, 2020 •

edited

Loading

mstad commented May 13, 2020 •

edited

Loading

mstad commented May 13, 2020 •

edited

Loading

yxliang01 commented May 18, 2020 •

edited

Loading

mstad commented May 20, 2020 •

edited

Loading

mstad commented Jun 15, 2020 •

edited

Loading

yxliang01 commented Jun 16, 2020 •

edited

Loading

mstad commented Jun 26, 2020 •

edited

Loading

yxliang01 commented Oct 15, 2020 •

edited

Loading