Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with galleryplus v15.1 #27

Open
vader2014 opened this issue Jun 22, 2016 · 6 comments
Open

incompatible with galleryplus v15.1 #27

vader2014 opened this issue Jun 22, 2016 · 6 comments

Comments

@vader2014
Copy link

hi

if i enable files_mv and the gallery+ v15.1 then the loading of the gallery page is broken (it does not load the thumbnail pictures) and i have the following in the firefox error console:

TypeError: OCA.Files.fileActions is undefined
OCA.Files_mv.Move.registerFileAction()  fe0048b3a4b543118843b12a9863d4d8.js:817
OCA.Files_mv.Move.initialize()  fe0048b3a4b543118843b12a9863d4d8.js:818
<anonymous> fe0048b3a4b543118843b12a9863d4d8.js:820
x.Callbacks/c() fe0048b3a4b543118843b12a9863d4d8.js:4
x.Callbacks/p.fireWith() fe0048b3a4b543118843b12a9863d4d8.js:4
.ready() fe0048b3a4b543118843b12a9863d4d8.js:4
q() fe0048b3a4b543118843b12a9863d4d8.js:4
waitForSyncCallback() async.js:98
_sleep()
SyncEngine.prototype._uploadOutgoing() engines.js:1500
SyncEngine.prototype._sync()  engines.js:1553
WrappedNotify()  util.js:146
Engine.prototype.sync()  engines.js:670
_syncEngine()  enginesync.js:213
sync()  enginesync.js:1638
onNotify()  service.js:1262
WrappedNotify()  util.js:146
WrappedLock()  util.js:101
_lockedSync()  service.js:1252
sync/<()  service.js:1244
WrappedCatch()  util.js:75
sync()  service.js:1232
bound sync()  self-hosted:750

if needed i can contribute to the fixing e.g. via testing

@oparoz
Copy link

oparoz commented Jun 22, 2016

I believe files_mv is not being used on public shares, so the solution is to use loadAdditionalScripts here:
https:/eotryx/oc_files_mv/blob/master/appinfo/app.php#L14

@oparoz
Copy link

oparoz commented Jun 22, 2016

$eventDispatcher = \OC::$server->getEventDispatcher();
$eventDispatcher->addListener(
    'OCA\Files::loadAdditionalScripts',
    function() {
        \OCP\Util::addScript('files_mv', 'move');
        \OCP\Util::addStyle('files_mv', 'mv');
    }
);

@eotryx

@vader2014
Copy link
Author

works! thx!

@oparoz
Copy link

oparoz commented Jun 22, 2016

Cool :)

@Huster-at-github
Copy link

When will the issue with Gallery+ be fixed?
Does anyone still develop this app?

oparoz added a commit to oparoz/oc_files_mv that referenced this issue Jul 14, 2016
@godfuture
Copy link

I just disabled this app as the my gallery was totally empty.
https://help.nextcloud.com/t/gallery-app-is-completely-empty/3890

NC 10.0
Gallery 15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants