-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a "sync this group" notification type #362
Comments
@nmalzieu trying to clean up some of these older issues I believe we already catch most of these from a push notification perspective (correct me if I'm wrong), but we are not doing syncing only notifications My understanding of this is is for messages like group updates (member or metadata changes), we will want to sync the group Is that understanding correct? |
@alexrisch yes sometimes the group change notification payload is bigger than APNS / FCM's payload max size and so it fails We could probably
Maybe we can be smarter than that and also understand during the sync what the latest event was and still show a notification but more work for sure |
@nmalzieu thank you for the background info, I'll add additional details and add it to the backlog, assigning back to me for now |
Dev Direction:iOSUpdate ios/ConverseNotificationExtension/NotificationService.swift to handle new type from backend changes AndroidUpdate android/app/src/main/java/com/converse/dev/NotificationParser.kt to parse new type from backend changes |
Some notifications for some commit messages (adding and removing users in a big group) would also be big enough to go over Apple's limit.
Let's catch it and just send a "sync group" notification which might help with forked state
The text was updated successfully, but these errors were encountered: