feat: Move Pinned Conversation Indicator #922
Draft
+19
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved Pinned Conversation indicator to left of title Removed Avatar Indicator Cleaned up style of indicator to be more reusable
|
Let's tag @covrter for visibility on these smaller visual adjustments going forward |
|
Great shout, thanks y'all |
|
Fine to do incrementally imo! |
thierryskoda
reviewed
Oct 5, 2024
| <Text style={styles.text}>{title}</Text> | ||
| <View style={styles.textContainer}> | ||
| {showUnread && ( | ||
| <View> |
There was a problem hiding this comment.
Why wrapping with this View?
thierryskoda
reviewed
Oct 5, 2024
|
Will hold onto this PR for a bit while we get the design system in place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Pinned Conversation indicator to left of title Removed Avatar Indicator
Cleaned up style of indicator to be more reusable
Closes #920