Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md out of date? #330

Closed
christianparpart opened this issue Sep 19, 2023 · 7 comments · Fixed by #335
Closed

README.md out of date? #330

christianparpart opened this issue Sep 19, 2023 · 7 comments · Fixed by #335

Comments

@christianparpart
Copy link

Section Config: https:/erikw/tmux-powerline#config-file

seems to be wrong, or at least out of date. I have zero prior knowledge of tmux-powerline (nor tpm), but i barely made it working. Now, the problem seems to be I cannot configure it. Despite trying to follow the config section in the README.md, which is partly wrong, I feel like my changes to ~/.tmux-powerlinerc are ignored.

Most importantly, the segments are showing way to much, like everything (so it feels), so I tried to find not to display that much, like, disabling some things, like ifstat.sh, but I seem not to find the documentation that tells me how to. - Do you have any hints for me?

Many thanks.

@erikw erikw closed this as completed in 4b23381 Sep 25, 2023
@erikw
Copy link
Owner

erikw commented Sep 25, 2023

The README is updated to not reference the old configuration file ~/.tmux-powerlinerc anymore, only the new ~/.config/tmux-powerline/config.sh.

@benjaminmikiten
Copy link

benjaminmikiten commented Oct 1, 2023

I ended up here, trying to follow the README, and hope to add some context for anyone else who comes looking.

After some digging, I found that when paths.sh tries to set the $TMUX_POWERLINE_RCFILE it looks to see if ~/.config/tmux-powerline is set, and defaults to the old .tmux-powerlinerc if it's not.

If you've installed this with tpm, you may find that ~/.config/tmux-powerline/config.sh.default hasn't been created, as ~/.config/tmux-powerline will be in ~/.config/tmux/plugins/tmux-powerline, causing the paths.sh function above to use a .tmux-powerlinerc isntead.

@erikw erikw reopened this Oct 1, 2023
erikw added a commit that referenced this issue Oct 1, 2023
This path has been deprecated for a while. It seems to cause some issues
in #330, so it's maybe time to remove it.

Create a new major release after this is merged.

Fixes #330
@erikw
Copy link
Owner

erikw commented Oct 1, 2023

@benjaminmikiten interesting. Maybe it's time to remove support for that old configuration file ~/.tmux-powerlinerc to make the code easier and more stable.

Could you test if this PR solves the problem?
#335

You can check the PR out with

$ cd you/tmux-powerline/clone
$ git fetch origin pull/335/head:fix-330

@benjaminmikiten
Copy link

Yes, I'll confirm these changes -- just one moment.

@benjaminmikiten
Copy link

benjaminmikiten commented Oct 1, 2023

Running ./generate_rc throws an error from line 107 of rcfile.sh saying that config.sh.default doesn't exist.

The file it's trying to pipe to is at ~/.config/tmux-powerline/config.sh.default but my tmux-powerline folder is in ~/.config/tmux/plugins

@erikw
Copy link
Owner

erikw commented Oct 1, 2023

@benjaminmikiten Thank you for testing. I could replicate this by removing my ~/.config/tmux-powerline dir.

Could you update the PR branch to the latest commit and try again please?

@benjaminmikiten
Copy link

That did it! I now have a ~/.config/tmux-powerline. Thank you!

@erikw erikw closed this as completed in #335 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants