Eliminate "mutable variables" #6877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler would generate incorrect code for the
following type of expression:
Pattern = BoundVar1 = . . . = BoundVarN = Expression
An exception should be raised if any of the bound variables have
different values than `Expression`. The compiler would generate code
that would cause the bound variables to be bound to the value of
`Expression` whether the value matched or not.
For example:
t() ->
Zero = 0,
One = 1,
Result = One = Zero,
{Result,One,Zero}.
There should be a `badmatch` exception, but instead, the `t/0`
function returned `{0,0,0}`.
Closes erlang#6873
bjorng
added
team:VM
CT Test Results 2 files 253 suites 9m 18s ⏱️ Results for commit bff8f7e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
deleted the
bjorn/compiler/fix-mutable-variables/24/GH-6873/OTP-18470
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler would generate incorrect code for the following type of expression:
An exception should be raised if any of the bound variables have different values than
Expression. The compiler would generate code that would cause the bound variables to be bound to the value ofExpressionwhether the value matched or not.For example:
There should be a
badmatchexception, but instead, thet/0function returned{0,0,0}.Closes #6873