Do not ignore everything starting with underscore recursively #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have other things in your project structure, e.g. `scripts/__main__.py` it would be ignored with the simple rule `_*` ("anything that starts with underscore anywhere").
It's better to use `./_*` meaning "anything that starts with underscore in the root folder (e.g. `_build`).
|
Maybe should just list out the known dirs, |
Instead of ignoring everything that starts with an underscore, which is too broad.
|
@tsloughter Great suggestion, implemented and pushed (please squash when merging, or let me know and I’ll do it). |
|
and merged, we'll see if other stuff comes up but we should be pretty decent about this now. |
|
I'm guessing _vendor is gonna show up after updates but that's maybe not a bad thing. |
|
@ferd I assume the point of |
|
The vendor/ directory is checked in, and _vendor/ is created as a backup and upgrading censored deps. |
|
But |
|
yeah. we could probably ignore it as well to be safe against people checking it in. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have other things in your project structure, e.g.
scripts/__main__.pyit would be ignored with the simple rule_*("anything that starts with underscore anywhere").It's better to use
./_*meaning "anything that starts with underscore in the root folder (e.g._build).