Print diagnostic when failing to get VSN with Git #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `collect_default_refcount/1` of `rebar_git_resource` did not log the error message when it failed to get the vsn number with its `git log` command. A diagnostic error message is now printed with the status code and output message of the failing command.
ferd
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
collect_default_refcount/1ofrebar_git_resourcedid not log the error message when it failed to get the vsn number with itsgit logcommand.I encountered this error with GitHub Actions CI (actions/checkout#1169)
and failed to find the appropriate error cause because there was no diagnostic logging from rebar.
According to the CONTRIBUTING documentation, a test should be attached with this PR but I'm not sure how to add a test for this.
Any guidance would be appreciated.