Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite DAG growth #2892

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Commits on Jun 1, 2024

  1. Prevent infinite DAG growth

    In some circumstances where files repeatedly get updated, such as when a
    .xrl file re-generates a .erl file on each compile run, the DAG analysis
    would repeatedly re-add edges for this file's dependencies (such as
    include files) to the DAG. Since the digraph module de-dupes vertices
    but not edges (duplicate edges is a valid use case), we add an explicit
    check for edge presence before re-adding them.
    
    This should properly prevent unexpected growth of DAG files.
    
    From manual testing, we get stability when going from a fresh DAG, but
    if it already had many dupes, the file size may jump around a bit
    regardless.
    ferd committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    e917d00 View commit details
    Browse the repository at this point in the history