Refactor PHPUnit bootstrap #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used as a template for Parsedown extensions (like Parsedown Extra) to reuse Parsedown's original tests. You can either extend tests (like ParsedownExtraTest) or reuse them unchanged (like CommonMarkTest). Parsedown extensions simply have to implement their own TestParsedown class (test/TestParsedown.php) and all original tests will run with a instance of this class, rather than a instance of the original Parsedown class. This PR is a follow-up to erusev/parsedown#423, i.e. you must merge erusev/parsedown#423 first, otherwise this doesn't work.
PhrozenByte
added a commit
to PhrozenByte/parsedown
that referenced
this pull request
Sep 5, 2016
This allows Parsedown extensions (like Parsedown Extra) to reuse existing Parsedown tests. See erusev/parsedown-extra#96 for details.
Failing tests don't break builds on purpose, Parsedown Extra doesn't fully comply with the CommonMark specs at the moment. We should switch to test/CommonMarkTest.php of erusev/parsedown later, see erusev/parsedown#423 for details.
cebe
reviewed
Oct 13, 2016
.travis.yml
Outdated
| - 5.6 | ||
| - 5.5 | ||
| - 5.4 | ||
| - 5.3 | ||
| - nightly | ||
| - hhvm | ||
| - hhvm-nightly |
There was a problem hiding this comment.
hhvm-nightly is not supported by travis anymore.
There was a problem hiding this comment.
... what is just temporary until Travis updates its infrastructure - something that will happen sooner rather than later, Ubuntu Precise's end-of-life is in about 6 months.
PhrozenByte
force-pushed
the
bugfix/PHPUnitTests
branch
from
a5ea358
to
0fbc751
Compare
aidantwoods
reviewed
Mar 1, 2018
.travis.yml
Outdated
| fast_finish: true | ||
| allow_failures: | ||
| - php: nightly | ||
| - php: hhvm-nightly | ||
|
|
||
| install: | ||
| - composer install | ||
| - composer install --prefer-dist |
There was a problem hiding this comment.
You'll want to prefer source here aidantwoods/SecureParsedown@3693641
There was a problem hiding this comment.
Aaaaaah, and I was wondering why the files are missing 😆 Thanks!
|
All fixed now. However, the build still fails. It's IMO a good idea to merge #85 before merging this PR (just with a updated version constraint for
|
PhrozenByte
force-pushed
the
bugfix/PHPUnitTests
branch
from
0fbc751
to
926e6f1
Compare
PhrozenByte
force-pushed
the
bugfix/PHPUnitTests
branch
from
2375d76
to
926e6f1
Compare
|
Here's our latest build with Parsedown 1.7.1: https://travis-ci.org/erusev/parsedown-extra/builds/350738061 Naturally the two unrelated regressions are still there 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used as a template for Parsedown extensions (like Parsedown Extra) to reuse Parsedown's original tests. You can either extend tests (e.g.
ParsedownExtraTestextendsParsedownTest) or reuse them unchanged (e.g.CommonMarkTest). Parsedown extensions simply have to implement their ownTestParsedownclass (filetest/TestParsedown.php) and all original tests will run with a instance of this class, rather than a instance of the originalParsedownclass.This PR is a follow-up to erusev/parsedown#423, i.e. you must merge erusev/parsedown#423 first, otherwise this doesn't work.
Here are the
phpunitruns ofCommonMarkTestandCommonMarkTestWeak:$ phpunit -c phpunit.xml.dist vendor/erusev/parsedown/test/CommonMarkTest.phpOutput: http://pastebin.com/ZVBjdmvK
$ phpunit -c phpunit.xml.dist vendor/erusev/parsedown/test/CommonMarkTestWeak.phpOutput: http://pastebin.com/G4cBLfCT