Allow parsedown to specify list start attribute

[aidantwoods]

(I think this should work)
Allow parsedown to specify list start attribute (see: #100 (comment))

[aidantwoods]

Okay this looks good.

There is 1 failure (which is entirely by design – to add the new feature)

[PhrozenByte]

@erusev: Increases CommonMark compliance, see http://spec.commonmark.org/0.26/#start-number (however, I didn't check the suggested code changes)

[aidantwoods]

I've removed a change I made that added a feature that already exists ;p
Have rewritten to use the existing functionality – guess that's what I get for skimming the code ;p

Checks still look good – still receiving (the expected) single failure

[PhrozenByte]

Can you please update the test? You just have to edit test/data/ordered_list.html 😃

Looks great to me! 👍

[aidantwoods]

Okay, this should be good (including tests).
Had to modify the test via file upload, as GitHub auto-appends a new line when saving o.0

[erusev]

Wouldn't it work if instead of line 505, you add the brackets on 506 and keep 510 unchanged?

[aidantwoods]

@erusev Sort of – the dot still needs to be excluded somehow, whether that's by grabbing all the numbers in the capture group, or by chopping off the last character (the dot).

These would be the changes for the former method

[erusev]

You are right.

How about this - 505 and 510 stay the same, but in the if at 516, work with the existing match and split it by "." to get the number.

[aidantwoods]

@erusev in-fact ignore my previous comment – that wouldn't work, since the number needs to be known before inserting it (to check if it is 1)

It would actually need to be more like this (with the string splitting to get the dot)

[erusev]

This looks much better.

Could you update the pull request?

Thanks.

[aidantwoods]

@erusev Done – as written in the screenshot, bar the explode function – build tests indicate PHP 5.3 had trouble navigating the array as it was returned by explode (guessing I'd have to use an intermediary variable – which impacts readability slighly IMO). So I've just used a preg_replace in its place to grab all the digits before the first ..

[erusev]

preg_replace is very slow, though - check this out: http://stackoverflow.com/questions/1744956/explode-and-get-a-value-in-one-line-of-code

[aidantwoods]

@erusev looks like stristr is working as expected 😃 any other changes?

[erusev]

Great, a few more :)

1. We don't use _ as a word separator
2. No need to remove empty lines
3. It'd be more consistent if the if block is surrounded by empty lines

[aidantwoods]

@erusev Syntax has been adjusted ;-)

[erusev]

Could you handle 2 more :)

1. Single quotes on "."
2. Empty line before the nested if

[aidantwoods]

@erusev Okay, that should be done now? 😜

[erusev]

Nice, that's perfect 🎉

[aidantwoods]

@erusev Nice! 😃 Guess it's probably safe to close #100 and its duplicates now

[erusev]

Yep :) Thanks