Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Issue build error when Parsedown::version isn't up-to-date #560

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

PhrozenByte
Copy link
Contributor

As suggested in #556 (comment) 😃

@PhrozenByte
Copy link
Contributor Author

The failing build doesn't seem to be related to this PR, if you want to test it you could try restarting the build.

.travis.yml Outdated
@@ -26,3 +26,4 @@ install:
script:
- vendor/bin/phpunit
- vendor/bin/phpunit test/CommonMarkTestWeak.php || true
- [ -z "$TRAVIS_TAG" ] || [ "$TRAVIS_TAG" == "$(php -r 'require("Parsedown.php"); echo Parsedown::version;')" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL $TRAVIS_TAG 😃

@aidantwoods
Copy link
Collaborator

Travis is doing something strange...
screen shot 2018-02-28 at 18 16 24


@PhrozenByte
Copy link
Contributor Author

PhrozenByte commented Feb 28, 2018

Indeed, very strange... It says "Partially Degraded Service" - see https://www.traviscistatus.com/

Can you try restarting the build?

@aidantwoods
Copy link
Collaborator

aidantwoods commented Feb 28, 2018

Indeed, very strange... It says "Partially Degraded Service" - see https://www.traviscistatus.com/

Hmm... maybe we should give it a few mins

The failing build doesn't seem to be related to this PR, if you want to test it you could try restarting the build.

I think you can usually do something like

git commit --amend
git push --force

to do that ;-) (new commit hash), make sure you pull your changes down first though aha

(I can't restart the build from my end)

@PhrozenByte
Copy link
Contributor Author

As a collaborator you can restart builds by navigating to https://travis-ci.org/erusev/parsedown/builds/347396937, logging in and clicking the "Restart" button 😉

Anyway, it seems like there was some weird escaping issue I've never experienced before... It works now 😃

@aidantwoods aidantwoods merged commit d638fd8 into erusev:master Feb 28, 2018
@aidantwoods
Copy link
Collaborator

aidantwoods commented Feb 28, 2018

I'm logged in to Travis, but restart is not where it normally is 🤷‍♂️

screen shot 2018-02-28 at 19 09 01

v.s. something like
screen shot 2018-02-28 at 19 11 48

Anyway, guess it doesn't matter so much now ;p

@PhrozenByte
Copy link
Contributor Author

PhrozenByte commented Feb 28, 2018

Weird... Maybe Travis needs some time to update the permissions? Because Collaborators definitly have the right to restart builds (I'm using it on some repos I'm a Collaborator of).

You might want to try it: Simply create a tag "test" (something that isn't seen as version constraint by Packagist/composer), push the tag and wait for the notification mail that the build failed. You can delete the tag afterwards (git tag -d test + git push origin :test). You might want to use your fork for testing purposes. Surely I tested it locally, but who knows 😆

@aidantwoods
Copy link
Collaborator

Looks like it works :)

https://travis-ci.org/erusev/parsedown/builds/347425487

@PhrozenByte
Copy link
Contributor Author

🎉 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants