Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IABookReader view mode work with IIIF Presentation Manifest API 3.0 for both PDFs and creative work series #184

Closed
patdunlavey opened this issue Apr 1, 2022 · 3 comments
Closed

Make IABookReader view mode work with IIIF Presentation Manifest API 3.0 for both PDFs and creative work series #184

patdunlavey opened this issue Apr 1, 2022 · 3 comments
Assignees
@patdunlavey
Labels
enhancement New feature or request IIIF Specs/Manifests/Implementations Javascript Favourite language of a PHP developer
Milestone
1.0.0

Comments

@patdunlavey
Copy link
Collaborator

This will entail reworking plugin.iiif-iabookreader_strawberry.js to detect the IIIF manifest version, and implementing a separate parsing pipeline for version 3.0.

To display creative work series using the book reader, it should be configured like this:
Screenshot from 2022-04-01 16-41-59
Screenshot from 2022-04-01 16-42-18

To display PDF object documents should only require changing the display template like this:
Screenshot from 2022-04-01 16-45-33

Supporting HOCR in creative work series that are displayed in the IABookReader will be another issue.
@DiegoPino
Copy link
Member

@patdunlavey thanks. I already made a refactor of the IIIF Manifests involved to match this. Will commit to Deployment repos in 1.0.0 version by Monday. HOCR is already in the works.

@DiegoPino DiegoPino added enhancement New feature or request Javascript Favourite language of a PHP developer IIIF Specs/Manifests/Implementations labels Apr 1, 2022
@DiegoPino DiegoPino added this to the 1.0.0 milestone Apr 1, 2022
DiegoPino added a commit that referenced this issue Apr 1, 2022
@DiegoPino
Merge pull request #181 from Born-Digital-US/tasks/24607546-cws-to-iab
1e87a72 
ISSUE #184: Enable Creative Work Series and PDF to be displayed in IABookReader using IIIF Presentation API 3.0 Manifest
@DiegoPino
Copy link
Member

Resolved via 1e87a72
Thanks so much @patdunlavey for your great work on this. It is a delight to review your code! 🥳

@patdunlavey
Copy link
Collaborator Author

Thank you @DiegoPino !

@DiegoPino DiegoPino mentioned this issue Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patdunlavey patdunlavey

Labels
enhancement New feature or request IIIF Specs/Manifests/Implementations Javascript Favourite language of a PHP developer
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@patdunlavey @DiegoPino