ISSUE-177: Initialize embargo cache arrays sooner #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ADO has no media, wrong metadata, etc, and we can not show anything we still are merging the cache tags, so put the to [] sooner
|
@DiegoPino it works perfect, no more errors. Thanks best bug solver friend! |
giancarlobi
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #177. This really applies to any Formatter and only fails if there is no media at all to show. This fixes it but @aksm @alliomeria @giancarlobi I'm not totally happy still with the refactor for formatters. I might push another (different issue) before 1.0.0
@giancarlobi can you please test tomorrow?
Thx