ISSUE-182: Make Metadata Display Entities Revisionable #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
reviewed
Jul 19, 2022
format_strawberryfield.install
Outdated
| ]); | ||
| $definition_update_manager->installFieldStorageDefinition('revision_log_message', $entity_type_id, $entity_type_id, $revision_log_message); | ||
| //$last_installed_schema_repository = \Drupal::service('entity.last_installed_schema.repository'); | ||
| //$field_storage_definitions = $last_installed_schema_repository->getLastInstalledFieldStorageDefinitions('metadatadisplay_entity'); |
There was a problem hiding this comment.
@aksm why are these lines commented out?
There was a problem hiding this comment.
Meant to delete those when I realized they needed to be in the post_update hook.
added 12 commits
July 19, 2022 21:40
…tatus doesn't cause error (still no value though).
CiteProc folders updated.
Forgot to import CiteProc's StyleSheet class.
…eated automatically, and change hook dependency number to correct one.
…testing, but woohoo!
|
@aksm I will get back to this soon. I need to check what happens with revisions v/s our actual load/entity practices before merging. Will put something in my calendar for Wednesday March 22nd 2023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs work, but begins to resolve #182