ISSUE-247: Fixes Search API twig extension #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Checks the Type of the Solr item before trying to load it - Deals with one possible exception (more to come) - Raises the Facet number for now to 100. This can be an extra setting, per facet field i guess?
DiegoPino
added
bug
Strange thing i learned late night If i do entity loading/field extraction the current Open Drupal SESSION gets crazy and if the extension is being used on e.g a Display template the ADO is shown as anonymous user! QueryInterface::PROCESSING_FULL changes everything triggering internally Access Control and then affecting the normal flow. This makes things also faster. We only return the Solr fields and the Entity ID e.g entity:node/6795:en which allows us then, on the template IF needed to load if based on a pattern.
aksm
reviewed
Jan 23, 2023
src/TwigExtension.php
Outdated
|
|
||
| if ($result_object) { | ||
| foreach ($resultItem->getFields() as $field) { | ||
| $return['results'][$itemid]['fields'][$field->getFieldIdentifier()] |
There was a problem hiding this comment.
It looks like previously the key for the returned results was the node id, but it's now the $itemid, e.g. entity:node/15:en. Is that right?
There was a problem hiding this comment.
Yes, because we can't load the Entity to get the real ID. We could split it upfront to get the entity but that said having a way to letting the user know (via the ID) what entity was fetched and the language might be good (means entity:node/15:en seems a way of doing that)
aksm
approved these changes
Jan 24, 2023
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #247
Won't go crazy with Strawberry Flavor results
Needs probably more testing/more exception catching