ISSUE-280b:Trimming was needed. But we want to preserve spaces at least #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What? So, when you trim you also remove return carriages, tabs, etc. The explode on line break leaves \r which then won't match. This now trims modally only but also removes the already matched values from the list making this also, wait for it, FASTER!
DiegoPino
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
So, when you trim you also remove return carriages, tabs, etc. The explode on line break leaves \r which then won't match. This now trims modally only but also removes the already matched values from the list making this also, wait for it, FASTER! Means on each existing facet I only check for the excluded items that DID not match before. Good Diego
@alliomeria will update now. Sorry for the error/missunderstanding of the code 😵💫