ISSUE-345: left over SBF Ajax interactions when enabling Ajax, then enabling interactions, then disabling Ajax again #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bling ajax Now we will show/but disabled on the absence of "use Ajax" but also clear if after setting this up, Ajax is disabled. Also made sure the wording is accurate. Right now we process Contextual filter values/exposed on path values. Not form driven exposed arguments (imagine the mess if we did that)
Bc views are a mess. I messed up a path, which then did not longer was valid, and because of that Ajax itself died. That is actually OK BC drupal should not even allow a Path to be visible if it is invalid! (according to its own validation methods) but bc it allows it to be there (caching, who knows) at least i can avoid generating any GET/URL/Browser history if that is the case
DiegoPino
added
bug
DiegoPino
changed the title
|
@DiegoPino Makes sense and not noticing any obvious problems with this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #345
Also did a small work-around a bug in Drupal: A non valid (bc I messed it up) Views Page Path will still render a page but basically not work. In that case I can not generate a browser history. I mean nothing will work, but at least it won't be because of our code.
Also the wording of our display extender was "improved". We only allow relationships and Contextual filters to be "fed" by a viewer/ado. Not pure exposed filters that could be modified by the user via a form (that would be a great/extra mess if we did).I mean, an exposed filter "could" be used, but only if also used as contextual. You all know what I mean (or not!)
@alliomeria this solves the array error we saw today.