ISSUE-385: Drupal 10.1 compatibility for our overriden Controllers/facet/exposed forms (Symphony 5 v/s GET) #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony bag ... thanks Drupal 10.1 ...
options.data might be null, undefined, etc. Who knows
DiegoPino
added
enhancement
DiegoPino
added a commit
to esmero/archipelago-deployment-live
that referenced
this pull request
Dec 12, 2023
"egulias/email-validator": "^3.2" makes all stay in 10.0.x "egulias/email-validator": "^4" allows to move forward but we need esmero/format_strawberryfield#391 to be tested and merged before that
|
@alliomeria @WWU-MaxBronsema I tested this pull against 1.3.0 on Drupal 10.0.x. Does not work. The breaking change in Drupal 10.1 (Views using GET arguments) is backwards compatible with this. Means I will have to roll a release later this weekend. Will move fast and let you all know. It will be a 1.3.1 not a 1.4.0 (so we don't have to write new documentation). Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #385
This enables us to move forward with Drupal 10.1. Views now use by default GET which also means the arguments we need for our overrides for facets/ custom exposed form block approach are somewhere else.
I'm not sure of these changes work with 10.0.x so for now will pull against 1.3.0 but might have to change my mind and roll YET another release. (thanks blue drop)