ISSUE-404: Facet summary with separate entries per Input/field for advanced search #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't act on these yet. On classic mode the default behavior (invisible to the user) will be to render all allowed filters BUT hide them initially. That way the plus and minus signs really only do "show/hide" and unset values instead of depending on a complex logic on the Actual exposed form handler for the filter. This also allows the Filter still have full control of how many/naming, etc. All this via JS
…idding (visually hidden v/s hidden via js?) or data attributes? not sure yet
'aria-hidden' = TRUE allows us to also hide them for screen readers. If not this is just too confusing for an enduser
…c mode Works. No submit until user presses "Apply" or search or whatever the "op" button is named. But... i still need to refine the remove logic. Bc as "requested" there could be a MINUS button per sub filter, which means also, when someone presses [add]. i Basically need to reorder the values so there are no "empty" gaps which right now happens when i hide/unhide elements,. Baby steps @alliomeria
…istent order (i tried, god knows i tried @alliomeria) but, i can shift and move values so i can always remove from the end, add to the end, but delete the value from the actual position i am requested and via JS move values one step down. Which in UX terms i like if i had actually removed the specific field...
…st one now Edge case, the last one is the current one... deal with that Diego @alliomeria this will be ready to test tomorrow 9AM
Yay diego, yay
And now i got it right advanced_search_multiple_remove
Also: double quotes (surrounding) will check if a double quote exist already in the search term and add <em> around them to differentiate.
DiegoPino
added
enhancement
|
@alliomeria will do some testing now. Not sure yet if my logic works/makes sense. LOTs of array/moving things around, etc. If this works on my side I will ask you to test also during the week? Before the end of the week (bc I need to update a server during the weekend with this). Appreciate all your energies and efforts on this |
Needs more testing @alliomeria but i can delete a single one, etc.
@alliomeria i did it!
|
@alliomeria one issue I noticed - tomorrow but have to type now or I will forget- (which is not our processor I think?) is that if the facet block is set to OR (bad idea for advanced search) and we have 0 results, the current passed facet (e.g my own name) is not available to our processor (bc it is not part of the list) but also bc Drupal takes over the Facet summary (given than the facet block itself shows all the others to allow for an OR) it skips my logic and thus not showing the facet summary for the one that fails (my name, I fail)... hard to explain, will have to show tomorrow. Will double check the code if I can intercept/override this from the main Facet Summary. Seems like a bug to me |
i delete the values i know i want to remove ... that way also other Filters in the URL + the count stay stable... @alliomeria done (don't trust this). Will now test for 30 minutes or so trying to break all/the hell out of this and will report tomorrow in your afternoon. thanks
@alliomeria why? More testing tomorrow. This restores again the hot linking via GET of URLs that got lost in the most recent update to drupal 10.1 (the URL that auto updates + ajax via facet blocks/refresh which again after drupal 10.1 contained duplicated info (on GET and arguments) making the URLs after two Facet clicks wrong/unusable on the refreshed URL on the browser.
Also new in Drupal.Now any form adds the op to the submissions. So ugly
Now the show count respects also the global facet summary (per facet) selection. If disabled, we don't show it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #404 . I will keep pulling this against 1.4.0 but maybe we can just make all 1.3.0 and then close the Restaurant, turn the tables and wash the dishes?
Who knows