ISSUE-449: Fix multiple Contextual filters, some "NULL" and allow Exposed filters. But avoid if already set same "key" via a Cont… #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extual one Also, for contextual ones, use the "exception" value instead of NULL So we can avoid passing "NULL" and end being not validated because of that. $executable->exposed_data = $filters; was the trick ..
DiegoPino
added
bug
|
This works. Note. The Open API will not run any Views at all if none of the passed arguments is mapped to a Views argument or Filter. That is by design to avoid someone by mistake exposing their whole repository without a single filter (or though) via an API @alliomeria |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…extual one
Also, for contextual ones, use the "exception" value instead of NULL So we can avoid passing "NULL" and end being not validated because of that. $executable->exposed_data = $filters; was the trick ..
See #449
@alliomeria this should do the trick with OAI and a single View dealing with both listing and getting a single record. Will report tomorrow with a live implementation and simple instructions for this (so you can also have this in your local for future needs/users)