-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS query is issued in ssl_client's start_ssl_client method, even when IP address is provided #7350
Closed
1 task done
Labels
Status: In Progress
Issue is in progress
Comments
cziter15
changed the title
DNS query is issued in ssl_client.cpp - connect method, even when IP address is provided
DNS query is issued in ssl_client's start_ssl_client method, even when IP address is provided
Oct 14, 2022
Thanks for contribution, again, we'll review your PR and let you know :) |
VojtechBartoska
added
Status: In Progress
Issue is in progress
and removed
Status: Awaiting triage
Issue is waiting for triage
labels
Oct 21, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No details about the device required as whole ecosystem is affected.
Affected component: WiFiClientSecure, ssl_client and probably more...
Description
When using WiFiClient secure and passing IPAdddress, unnecessary DNS query flow is issued. Why is it ever calling hostByName function? That's probably caused by confusion of mbedtls hostname with endpoint hostname. On Arduino-esp8266 NULL is passed as hostname in this situation.
Expected resoultion:
When providing raw IP address, no DNS query should be issued. This can be partially fixed by #7351.
Hostname should be NULL (like in esp8266 Arduino core) or should be able to be defined by the user.
Sketch
I have checked existing issues, online documentation and the Troubleshooting Guide
The text was updated successfully, but these errors were encountered: