Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variant for Waveshare ESP32-S3-Zero #10241

Merged
merged 13 commits into from
Aug 26, 2024

Conversation

Y1hsiaochunnn
Copy link
Contributor

Description of Change

Added variant for ESP32-S3-Zero with RGB Light

Tests scenarios

Untested, pin definition is based on information in Waveshare wiki.

Related links

Wiki For ESP32-S3-Zero

Pending USB VID PR: espressif/usb-pids#174

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added variant for ESP32-S3-Zero":
    • summary looks empty
    • type/action looks empty
  • the commit message "Added variant for ESP32-S3-Zero":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix the partition without ota":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix waveshare esp32-s3-zero partition table, add 4MB partition content":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix waveshare esp32-s3-zero partition table, add 4MB partition content":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed CI failures due to I2C and SPI pin definitions":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fixed custom partitions":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update tools/partitions/max_app_4MB.csv":
    • summary looks empty
    • type/action looks empty
  • the commit message "change boards.txt":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 13 commits (simplifying branch history).

👋 Hello Y1hsiaochunnn, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2521a8a

@Y1hsiaochunnn
Copy link
Contributor Author

Hi @P-R-O-C-H-Y ,
how does it look now?

boards.txt Outdated Show resolved Hide resolved
@Y1hsiaochunnn
Copy link
Contributor Author

Fixed

boards.txt Outdated Show resolved Hide resolved
@P-R-O-C-H-Y
Copy link
Member

@Y1hsiaochunnn Also move the partitions from variant folder to tools/partitions.
Renaming to something like max_app_4MB and ota_nofs_4MB. Thanks

@Y1hsiaochunnn
Copy link
Contributor Author

i did it so,network is not good, so I amend it repeatedly

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/partitions/max_app_4MB.csv Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@Y1hsiaochunnn Y1hsiaochunnn changed the title Added variant for ESP32-S3-Zero Added variant for Waveshare ESP32-S3-Zero Aug 26, 2024
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 26, 2024
@me-no-dev me-no-dev merged commit dbdb402 into espressif:master Aug 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants