Fix I2C Slave Compile #6108
Merged
Fix I2C Slave Compile #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I2C Slave currently doesn't compile for projects where Arduino is an IDF component. This adds missing conditionals.
|
|
1 task
|
@mrengineer7777 This is needed too https:/tasmota/arduino-esp32/pull/47/files |
@Jason2866 That fix is in "esp32-hal-spi.c" and appears unrelated to my fix in "esp32-hal-i2c-slave.c". |
|
I thought you want to fix all issues when Arduino is used as IDF component. |
@Jason2866 Gotcha. I just found the repository "tasmota / arduino-esp32". Impressive work! |
|
The real impressive (why it is made) is the project which use -> https:/arendst/Tasmota |
|
@me-no-dev It appears the automated checks failed because of a network timeout. |
|
merged :) |
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I2C Slave currently doesn't compile for projects where Arduino is an IDF component. This adds missing conditionals.
Impact
esp32-hal-i2c-slave.c will compile
Related links
N/A